mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Salah Triki <salah.triki@acm.org>
To: akpm@linux-foundation.org
Cc: Salah Triki <salah.triki@acm.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: befs: use flags field to validate fs state
Date: Tue, 10 May 2016 19:59:42 +0100	[thread overview]
Message-ID: <1462906782-4432-1-git-send-email-salah.triki@acm.org> (raw)

flags field records the state of the superblock, so it is
more appropriate to use this field for validating the fs state than
using the fields log_start and log_end.

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/super.c b/fs/befs/super.c
index aeafc4d..079fc00 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@ -101,7 +101,7 @@ befs_check_sb(struct super_block *sb)
 		return BEFS_ERR;
 	}
 
-	if (befs_sb->log_start != befs_sb->log_end) {
+	if (befs_sb->flags == BFS_DIRTY) {
 		befs_error(sb, "Filesystem not clean! There are blocks in the "
 			   "journal. You must boot into BeOS and mount this volume "
 			   "to make it clean.");
-- 
1.9.1

             reply	other threads:[~2016-05-10 19:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 18:59 Salah Triki [this message]
2016-05-10 19:15 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462906782-4432-1-git-send-email-salah.triki@acm.org \
    --to=salah.triki@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®