From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbcEKRtL (ORCPT ); Wed, 11 May 2016 13:49:11 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33383 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcEKRtJ (ORCPT ); Wed, 11 May 2016 13:49:09 -0400 From: Muhammad Falak R Wani To: Christian Knig Cc: Alex Deucher , David Airlie , Rex Zhu , =?UTF-8?q?Nils=20Wallm=C3=A9nius?= , Dan Carpenter , Jammy Zhou , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amd/powerplay: use ARRAY_SIZE() for size of array Date: Wed, 11 May 2016 23:18:43 +0530 Message-Id: <1462988936-13486-1-git-send-email-falakreyaz@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use ARRAY_SIZE() for the size calculation of the array. Also move the condition evaulation function out of the for loop. Although, any respectable c-compiler would optimize this and evaluate the function only once outside the loop, but the optimzation engine of gcc is bit brain-dead, and at times needs some hand holding. Signed-off-by: Muhammad Falak R Wani --- drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c index da18f44..718a551 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c @@ -636,10 +636,11 @@ static int cz_smu_populate_firmware_entries(struct pp_smumgr *smumgr) int ret; enum cgs_ucode_id ucode_id; struct cgs_firmware_info info = {0}; + int n = ARRAY_SIZE(firmware_list); cz_smu->driver_buffer_length = 0; - for (i = 0; i < sizeof(firmware_list)/sizeof(*firmware_list); i++) { + for (i = 0; i < n; i++) { firmware_type = cz_translate_firmware_enum_to_arg(smumgr, firmware_list[i]); -- 1.9.1