From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932128AbcEKTXW (ORCPT ); Wed, 11 May 2016 15:23:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbcEKTXV (ORCPT ); Wed, 11 May 2016 15:23:21 -0400 From: Andrew Jones To: linux-kernel@vger.kernel.org Cc: sudeep.holla@arm.com, marc.zyngier@arm.com Subject: [PATCH] irqchip/gic-v3: fix quiescence check in gic_enable_redist Date: Wed, 11 May 2016 21:23:17 +0200 Message-Id: <1462994597-6299-1-git-send-email-drjones@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 11 May 2016 19:23:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Andrew Jones --- I'm unaware of any problems this may have caused. I only just saw it while reading over the code. drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 5b7d3c2129d87..518bc1799b4dc 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -147,7 +147,7 @@ static void gic_enable_redist(bool enable) while (count--) { val = readl_relaxed(rbase + GICR_WAKER); - if (enable ^ (val & GICR_WAKER_ChildrenAsleep)) + if (enable ^ (bool)(val & GICR_WAKER_ChildrenAsleep)) break; cpu_relax(); udelay(1); -- 2.4.11