From: Arnd Bergmann <arnd@arndb.de>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>, Len Brown <lenb@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Darren Hart <dvhart@linux.intel.com>,
Borislav Petkov <bp@suse.de>, Aaron Lu <aaron.lu@intel.com>,
Sudeep Holla <Sudeep.Holla@arm.com>,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI/video: mark acpi_video_get_levels inline
Date: Thu, 12 May 2016 23:00:12 +0200 [thread overview]
Message-ID: <1463086839-2466302-1-git-send-email-arnd@arndb.de> (raw)
A recent patch added a stub function for acpi_video_get_levels when
CONFIG_ACPI_VIDEO is disabled. However, this is marked as 'static'
and causes a warning about an unused function whereever the header
gets included:
In file included from ../drivers/gpu/drm/radeon/radeon_acpi.c:28:0:
include/acpi/video.h:74:12: error: 'acpi_video_get_levels' defined but not used [-Werror=unused-function]
This makes the declaration 'static inline', which gets rid of the
warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 059500940def ("ACPI/video: export acpi_video_get_levels")
---
include/acpi/video.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/acpi/video.h b/include/acpi/video.h
index a4b96c971564..70a41f742037 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -71,7 +71,7 @@ static inline bool acpi_video_handles_brightness_key_presses(void)
{
return false;
}
-static int acpi_video_get_levels(struct acpi_device *device,
+static inline int acpi_video_get_levels(struct acpi_device *device,
struct acpi_video_device_brightness **dev_br)
{
return -ENODEV;
--
2.7.0
next reply other threads:[~2016-05-12 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 21:00 Arnd Bergmann [this message]
2016-05-13 21:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463086839-2466302-1-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Sudeep.Holla@arm.com \
--cc=aaron.lu@intel.com \
--cc=bp@suse.de \
--cc=devel@acpica.org \
--cc=dvhart@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®