From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbcEMIos (ORCPT ); Fri, 13 May 2016 04:44:48 -0400 Received: from smtpout.microchip.com ([198.175.253.82]:38285 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751675AbcEMIop (ORCPT ); Fri, 13 May 2016 04:44:45 -0400 From: Purna Chandra Mandal To: CC: , , Purna Chandra Mandal , Mark Brown Subject: [PATCH] spi: pic32-sqi: Fix linker error, undefined reference to `bad_dma_ops'. Date: Fri, 13 May 2016 14:12:53 +0530 Message-ID: <1463128973-29831-1-git-send-email-purna.mandal@microchip.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even if DMA support is disabled code using DMA mapping APIs compiles fine, but fails in linking. ------- drivers/built-in.o: In function `ring_desc_ring_free': spi-pic32-sqi.c:(.text+0x2cfbe0): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cfbe4): undefined reference to `bad_dma_ops' drivers/built-in.o: In function `pic32_sqi_probe': spi-pic32-sqi.c:(.text+0x2cfe48): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cfeb0): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cff38): undefined reference to `bad_dma_ops' -------- Correct dependency by adding 'depends on HAS_DMA' in Kconfig. Signed-off-by: Purna Chandra Mandal --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 281ed5d..0f50755 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -445,6 +445,7 @@ config SPI_PIC32 config SPI_PIC32_SQI tristate "Microchip PIC32 Quad SPI driver" depends on MACH_PIC32 || COMPILE_TEST + depends on HAS_DMA help SPI driver for PIC32 Quad SPI controller. -- 1.8.3.1