From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbcENA7P (ORCPT ); Fri, 13 May 2016 20:59:15 -0400 Received: from mga04.intel.com ([192.55.52.120]:27759 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbcENA7O (ORCPT ); Fri, 13 May 2016 20:59:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,615,1455004800"; d="scan'208";a="102991522" From: "Pandruvada, Srinivas" To: "linux-kernel@vger.kernel.org" , "rcochran@linutronix.de" CC: "Zhang, Rui" , "edubezval@gmail.com" , "linux-pm@vger.kernel.org" , "rt@linutronix.de" Subject: Re: [PATCH 3/5] thermal: x86_pkg_temp: Handle the FROZEN hot plug notifier actions. Thread-Topic: [PATCH 3/5] thermal: x86_pkg_temp: Handle the FROZEN hot plug notifier actions. Thread-Index: AQHRrXvUeAMPgcXkf06kqM0f1kLSog== Date: Sat, 14 May 2016 00:59:13 +0000 Message-ID: <1463187520.7872.16.camel@intel.com> References: <1458336371-17748-3-git-send-email-rcochran@linutronix.de> In-Reply-To: <1458336371-17748-3-git-send-email-rcochran@linutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] Content-Type: text/plain; charset="utf-8" Content-ID: <8A45B0F290EE324A98629B9548467E37@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4E0xT1c007494 On Fri, 2016-03-18 at 22:26 +0100, Richard Cochran wrote: > When performing a suspend operation, the kernel brings all of the > non-boot CPUs offline, calling the hot plug notifiers with the flag, > CPU_TASKS_FROZEN, set in the action code.  Similarly, during resume, > the CPUs are brought back online, but again the notifiers have the > FROZEN flag set. > > While some very few drivers really need to treat suspend/resume > specially, this driver unintentionally ignores the notifications. > > This patch changes the driver to cancel its work item when the CPU > goes down, even during a suspend operation.  As a result, the > suspended state is no longer a special case. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: linux-pm@vger.kernel.org > Signed-off-by: Richard Cochran Reviewed-by: Srinivas Pandruvada > --- >  drivers/thermal/x86_pkg_temp_thermal.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/x86_pkg_temp_thermal.c > b/drivers/thermal/x86_pkg_temp_thermal.c > index 7fc919f..97f0a2b 100644 > --- a/drivers/thermal/x86_pkg_temp_thermal.c > +++ b/drivers/thermal/x86_pkg_temp_thermal.c > @@ -555,7 +555,7 @@ static int pkg_temp_thermal_cpu_callback(struct > notifier_block *nfb, >  { >   unsigned int cpu = (unsigned long) hcpu; >   > - switch (action) { > + switch (action & ~CPU_TASKS_FROZEN) { >   case CPU_ONLINE: >   case CPU_DOWN_FAILED: >   get_core_online(cpu);