From: Hou Pengyang <houpengyang@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>, <yuchao0@huawei.com>,
<bintian.wang@huawei.com>
Subject: [RFC] f2fs: fix a race condition between evict & gc
Date: Mon, 16 May 2016 10:40:21 +0000 [thread overview]
Message-ID: <1463395221-109622-1-git-send-email-houpengyang@huawei.com> (raw)
When collecting data segment(gc_data_segment), there is a race condition
between evict and phases of gc:
0) ra_node_page(dnode)
1) ra_node_page(inode)
<--- evict the inode
2) f2fs_iget get the inode and add it to gc_list
3) move_data_page
In step 2), f2fs_iget does NOT find the inode and allocs a new inode as result,
which is not resonable.
This patch changes f2fs_iget to ilookup. when no inode is found, no new inode is
created.
Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
---
fs/f2fs/gc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 38d56f6..6e73193 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -717,8 +717,8 @@ next_step:
ofs_in_node = le16_to_cpu(entry->ofs_in_node);
if (phase == 2) {
- inode = f2fs_iget(sb, dni.ino);
- if (IS_ERR(inode) || is_bad_inode(inode))
+ inode = ilookup(sb, dni.ino);
+ if (!inode || IS_ERR(inode) || is_bad_inode(inode))
continue;
/* if encrypted inode, let's go phase 3 */
--
1.9.1
next reply other threads:[~2016-05-16 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 10:40 Hou Pengyang [this message]
2016-05-16 15:10 ` [f2fs-dev] " Chao Yu
2016-05-17 3:00 ` Hou Pengyang
2016-05-17 17:23 ` Jaegeuk Kim
2016-05-18 10:52 ` Hou Pengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463395221-109622-1-git-send-email-houpengyang@huawei.com \
--to=houpengyang@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®