From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754127AbcEPPlc (ORCPT ); Mon, 16 May 2016 11:41:32 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:61587 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbcEPPla (ORCPT ); Mon, 16 May 2016 11:41:30 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:Cc:Subject:Date: Message-Id:X-Mailer; b=0sbgtYY1PD3RTHAMESGRm8B2BEJJR7Nx8KaJg0w3tBEOSTkUVqAxzlVL c7LZJyLlQcNRarzAiM0tW3VzwzqJAOfUsHZ/vswznX+SaLdq30hRzOkNu wkh8G1mSSkG0zhsAV+LmLYUUlB3br778T6kTbHh09Oj+fCQuCXUR0gC82 k=; X-LoopCount0: from 10.209.151.17 X-IronPort-AV: E=Sophos;i="5.24,627,1454997600"; d="scan'208";a="932183992" From: Mario Limonciello To: ming.lei@canonical.com Cc: LKML , Mario Limonciello Subject: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware Date: Mon, 16 May 2016 10:41:04 -0500 Message-Id: <1463413264-32500-1-git-send-email-mario_limonciello@dell.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dell_rbu previously would allow a userspace application to craft the payload after dell_rbu was loaded and abuse the udev userspace API. Instead require the payload to be crafted and placed in /lib/firmware/dell_rbu ahead of time. This adjusts dell_rbu to immediately load the firmware from /lib/firmware/dell_rbu when "init" is passed into image_type using the kernel helper. --- drivers/firmware/dell_rbu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c index d5f5b98..5ecf043 100644 --- a/drivers/firmware/dell_rbu.c +++ b/drivers/firmware/dell_rbu.c @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj, if (!rbu_data.entry_created) { spin_unlock(&rbu_data.lock); req_firm_rc = request_firmware_nowait(THIS_MODULE, - FW_ACTION_NOHOTPLUG, + FW_ACTION_HOTPLUG, "dell_rbu", &rbu_device->dev, GFP_KERNEL, -- 2.7.4