From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754681AbcEQDsE (ORCPT ); Mon, 16 May 2016 23:48:04 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:38139 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036AbcEQDsB (ORCPT ); Mon, 16 May 2016 23:48:01 -0400 From: Jiada Wang To: , CC: , , , , , Subject: [PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script Date: Tue, 17 May 2016 12:47:49 +0900 Message-ID: <1463456876-10580-4-git-send-email-jiada_wang@mentor.com> X-Mailer: git-send-email 2.4.5 In-Reply-To: <1463456876-10580-1-git-send-email-jiada_wang@mentor.com> References: <1463456876-10580-1-git-send-email-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previously in cyclic dma mode when sdma transfer fails for one buffer, it will mask BD_RROR flag for that buffer descriptor (BD). This flag won't be cleared unless a new cyclic dma transfer is prepared, so if sdma script next time iterates to the same BD, even this time the transfer is successful, but as BD_RROR flag is set, client side will still think the transfer failed. This patch clears BD_RROR flag before pass it to sdma script. Signed-off-by: Jiada Wang --- drivers/dma/imx-sdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 887e4e5..1489de0 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -671,6 +671,7 @@ static void sdma_handle_channel_loop(struct sdma_channel *sdmac) if (bd->mode.status & BD_RROR) sdmac->status = DMA_ERROR; + bd->mode.status &= ~BD_RROR; bd->mode.status |= BD_DONE; sdmac->buf_tail++; sdmac->buf_tail %= sdmac->num_bd; -- 2.4.5