From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932879AbcEQGKP (ORCPT ); Tue, 17 May 2016 02:10:15 -0400 Received: from m12-16.163.com ([220.181.12.16]:46942 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317AbcEQGKN (ORCPT ); Tue, 17 May 2016 02:10:13 -0400 From: Heloise To: akpm@linux-foundation.org, hannes@cmpxchg.org, firogm@gmail.com, vdavydov@virtuozzo.com, viro@zeniv.linux.org.uk Cc: linux-kernel@vger.kernel.org, os@iscas.ac.cn Subject: [PATCH] fs:efs:fix return value Date: Mon, 16 May 2016 23:02:23 -0700 Message-Id: <1463464943-4142-1-git-send-email-os@iscas.ac.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: EMCowACHPMK0tTpXFH8pAw--.41715S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruryxGFWUJr15XF1UJFy8AFb_yoW3Zwb_X3 yxJF4xu34qyr4YyF4UCayYyrZa9a12kw18GrWjkFsxWrZxZFyDWryDWwn3XFs5ur4ftrsx Jw1qvF9a9F4SvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0y5l5UUUUU== X-Originating-IP: [124.16.141.89] X-CM-SenderInfo: xnhu0vxosd3uhkbx1vxdwhqiywtou0bp/1tbiRBRsglSIOyHr8AAAsj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the function sb_bread() fails, the return value should be -EIO, fix it. Signed-off-by: Heloise --- fs/efs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/efs/super.c b/fs/efs/super.c index cb68dac..368f7dd 100644 --- a/fs/efs/super.c +++ b/fs/efs/super.c @@ -275,7 +275,7 @@ static int efs_fill_super(struct super_block *s, void *d, int silent) if (!bh) { pr_err("cannot read volume header\n"); - return -EINVAL; + return -EIO; } /* @@ -293,7 +293,7 @@ static int efs_fill_super(struct super_block *s, void *d, int silent) bh = sb_bread(s, sb->fs_start + EFS_SUPER); if (!bh) { pr_err("cannot read superblock\n"); - return -EINVAL; + return -EIO; } if (efs_validate_super(sb, (struct efs_super *) bh->b_data)) { -- 2.1.0