From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbcERRfi (ORCPT ); Wed, 18 May 2016 13:35:38 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:35827 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187AbcERRfg (ORCPT ); Wed, 18 May 2016 13:35:36 -0400 From: Laura Abbott X-Google-Original-From: Laura Abbott To: Jan Kara Cc: Laura Abbott , linux-kernel@vger.kernel.org Subject: [PATCH] udf: Check for IS_ERR in udf_get_pblock_meta25 Date: Wed, 18 May 2016 10:35:31 -0700 Message-Id: <1463592931-7157-1-git-send-email-labbott@fedoraproject.org> X-Mailer: git-send-email 2.5.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org udf_find_metadata_inode_efe returns an error pointer, not just NULL. Check the return with IS_ERR appropriately. Signed-off-by: Laura Abbott --- Came out of https://bugzilla.redhat.com/show_bug.cgi?id=1301295, I never heard back from the reporter so I've had this sitting around for a bit and haven't been able to confirm it fixes the crash. The logic makes sense for the crash though. --- fs/udf/partition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/udf/partition.c b/fs/udf/partition.c index 5f861ed2..a8ee7fc 100644 --- a/fs/udf/partition.c +++ b/fs/udf/partition.c @@ -329,7 +329,7 @@ uint32_t udf_get_pblock_meta25(struct super_block *sb, uint32_t block, } inode = mdata->s_mirror_fe; - if (!inode) + if (IS_ERR(inode)) return 0xFFFFFFFF; retblk = udf_try_read_meta(inode, block, partition, offset); } -- 2.5.5