mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alden Tondettar <alden.tondettar@gmail.com>
To: Jan Kara <jack@suse.com>
Cc: Laura Abbott <labbott@fedoraproject.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alden Tondettar <alden.tondettar@gmail.com>
Subject: [PATCH 0/3] udf: Metadata partition fixes
Date: Wed, 18 May 2016 14:09:15 -0700	[thread overview]
Message-ID: <1463605759-7616-1-git-send-email-alden.tondettar@gmail.com> (raw)

This patchset (hopefully) fixes a problem with loading some
Windows-generated UDF 2.5 filesystems, and two other problems I noticed
along the way. This has only been tested on a single NetBSD-generated
image (works before, works now) and a few Windows-7-generated images
(triggered KASAN and failed to mount before, works fine now), but I don't
have any other UDF 2.5 images to test it on.

As I was getting ready to post this, I noticed on lkml that Laura Abbott has
just posted a similar fix (https://lkml.org/lkml/2016/5/18/489) for the
IS_ERR issue. However, I _think_ that fix is inadequate as iput() called
from udf_free_partition() will still dereference the error pointer in
s_mirror_fe on unmount.  If I'm wrong and that patch is fine, then let me
know if you want me to rework this to account for it.

Also, should MAINTAINERS list linux-fsdevel under UDF?

Alden Tondettar (3):
  udf: Don't BUG on missing metadata partition descriptor
  udf: Use IS_ERR when loading metadata mirror file entry
  udf: Use correct partition reference number for metadata

 fs/udf/partition.c | 13 +++++++++----
 fs/udf/super.c     | 22 ++++++++++++----------
 fs/udf/udf_sb.h    |  1 +
 3 files changed, 22 insertions(+), 14 deletions(-)

-- 
2.1.4

             reply	other threads:[~2016-05-18 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 21:09 Alden Tondettar [this message]
2016-05-18 21:09 ` Alden Tondettar
2016-05-18 21:09 ` [PATCH 1/3] udf: Don't BUG on missing metadata partition descriptor Alden Tondettar
2016-05-19 10:25   ` Jan Kara
2016-05-18 21:09 ` [PATCH 2/3] udf: Use IS_ERR when loading metadata mirror file entry Alden Tondettar
2016-05-19 10:25   ` Jan Kara
2016-05-18 21:09 ` [PATCH 3/3] udf: Use correct partition reference number for metadata Alden Tondettar
2016-05-19 11:03   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463605759-7616-1-git-send-email-alden.tondettar@gmail.com \
    --to=alden.tondettar@gmail.com \
    --cc=jack@suse.com \
    --cc=labbott@fedoraproject.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®