From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbcEWKxj (ORCPT ); Mon, 23 May 2016 06:53:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:46300 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbcEWKxh (ORCPT ); Mon, 23 May 2016 06:53:37 -0400 From: "'Max Staudt" To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: mstaudt@suse.de, eich@suse.de, tiwai@suse.de, thellstrom@vmware.com, tomi.valkeinen@ti.com Subject: [PATCH 1/3] Add missing "goto out" after fbops->fb_open() Date: Mon, 23 May 2016 12:48:51 +0200 Message-Id: <1464000533-13140-2-git-send-email-mstaudt@suse.de> X-Mailer: git-send-email 2.6.6 In-Reply-To: <1464000533-13140-1-git-send-email-mstaudt@suse.de> References: <1464000533-13140-1-git-send-email-mstaudt@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Max Staudt It doesn't make sense to execute any further actions after a failed call to fbops->fb_open(). Signed-off-by: Max Staudt --- drivers/video/fbdev/core/fbmem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 76c1ad9..913c496 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -1462,8 +1462,10 @@ __releases(&info->lock) file->private_data = info; if (info->fbops->fb_open) { res = info->fbops->fb_open(info,1); - if (res) + if (res) { module_put(info->fbops->owner); + goto out; + } } #ifdef CONFIG_FB_DEFERRED_IO if (info->fbdefio) -- 2.6.6