From: "'Max Staudt" <mstaudt@suse.de>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: mstaudt@suse.de, eich@suse.de, tiwai@suse.de,
thellstrom@vmware.com, tomi.valkeinen@ti.com
Subject: [PATCH 2/3] Define fb_open_adj_file()
Date: Mon, 23 May 2016 12:48:52 +0200 [thread overview]
Message-ID: <1464000533-13140-3-git-send-email-mstaudt@suse.de> (raw)
In-Reply-To: <1464000533-13140-1-git-send-email-mstaudt@suse.de>
From: Max Staudt <mstaudt@suse.de>
This callback from fb_open() allows a fbdev driver to adjust things such
as file->f_mapping to better represent the internal structures.
This is needed to allow TTM drivers using ttm_fbdev_mmap() to properly
set file->f_mapping to TTM's address_space from bo->bdev->dev_mapping,
as is done form /dev/drm/card* in drm_open().
Currently, bochsdrmfb is the only driver requiring this, and this
patch is a prerequisite to implement this in bochsdrmfb.
Signed-off-by: Max Staudt <mstaudt@suse.de>
---
drivers/video/fbdev/core/fbmem.c | 13 +++++++++++++
include/linux/fb.h | 7 +++++++
2 files changed, 20 insertions(+)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 913c496..ff5000e 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1471,6 +1471,19 @@ __releases(&info->lock)
if (info->fbdefio)
fb_deferred_io_open(info, inode, file);
#endif
+ if (info->fbops->fb_open_adj_file) {
+ res = info->fbops->fb_open_adj_file(info, file);
+ if (res) {
+ /* If we got here, we also want to undo anything
+ * that fbops->fb_open() may have done.
+ */
+ if (info->fbops->fb_release)
+ info->fbops->fb_release(info,1);
+
+ module_put(info->fbops->owner);
+ goto out;
+ }
+ }
out:
mutex_unlock(&info->lock);
if (res)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index dfe8835..4131496 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -320,6 +320,13 @@ struct fb_ops {
/* called at KDB enter and leave time to prepare the console */
int (*fb_debug_enter)(struct fb_info *info);
int (*fb_debug_leave)(struct fb_info *info);
+
+ /* Called after fb_open() to adjust mappings when using
+ * complex backends such as TTM.
+ * For example, the bochsdrmfb driver needs to adjust
+ * file->f_mapping so it can use ttm_fbdev_mmap().
+ */
+ int (*fb_open_adj_file)(struct fb_info *info, struct file *file);
};
#ifdef CONFIG_FB_TILEBLITTING
--
2.6.6
next prev parent reply other threads:[~2016-05-23 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 10:48 [PATCH 0/3] Fix kernel WARNING in TTM/Bochs KMS driver 'Max Staudt
2016-05-23 10:48 ` [PATCH 1/3] Add missing "goto out" after fbops->fb_open() 'Max Staudt
2016-05-23 10:48 ` 'Max Staudt [this message]
2016-05-23 13:44 ` [PATCH 2/3] Define fb_open_adj_file() Daniel Vetter
2016-05-24 16:28 ` Max Staudt
2016-05-24 16:51 ` Daniel Vetter
2016-05-25 16:06 ` Max Staudt
2016-05-23 10:48 ` [PATCH 3/3] Add fb_open_adj_file() to bochsdrmfb to avoid use-after-free 'Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464000533-13140-3-git-send-email-mstaudt@suse.de \
--to=mstaudt@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=eich@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
--cc=tiwai@suse.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®