From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755204AbcEWMBc (ORCPT ); Mon, 23 May 2016 08:01:32 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.145]:34189 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754898AbcEWMBU (ORCPT ); Mon, 23 May 2016 08:01:20 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRWlGSWpSXmKPExsVyU6Zroi7nR6d wg0mb5C3+31nEatG8eD2bxeVdc9gsFi1rZbZYsPERowOrx/65a9g9jt/YzuTxeZNcAHMUa2Ze Un5FAmvGkYlv2Qq+cFWsb1BqYFzP2cXIxSEksJ5R4uaVF4xdjJwcbAJmErterWMHsUUEhCQ6d 3xgAiliFljNKHF23ko2kISwQIjE/GPzWEBsFgFViaPrHjKB2LwCfhLXn10AsyUE5CRunutkBr E5BfwlfjbdYwWxhYBq3jZuhqoXlDg58wnYHGYBCYmDL14wQ9RoSyzf08cOMUdBYvaqDVAzkyX aH91lgbCtJdr+fmCfwCgwC8moWUhGLWBkWsWoXpxaVJZapGusl1SUmZ5RkpuYmaNraGCql5ta XJyYnpqTmFSsl5yfu4kRGL4MQLCDce8/p0OMkhxMSqK8J3c4hQvxJeWnVGYkFmfEF5XmpBYfY pTh4FCS4P38HignWJSanlqRlpkDjCSYtAQHj5II73qQNG9xQWJucWY6ROoUoy7Hh8nX1zIJse Tl56VKifMeASkSACnKKM2DGwGL6kuMslLCvIxARwnxFKQW5WaWoMq/YhTnYFQS5v0CMoUnM68 EbtMroCOYgI54KO0AckRJIkJKqoFx13G5b6/v97JtLjtpMGni2XXvKzctzH0lMzloKUeF+ckp 8XVurM++X05at7Ag7o6mXq7a4awAzo0npfZskYw9NH9vYuil2J/cHwMvf9KMbvsZvKVRpSrsJ vO8bVq5tW3B/5bePBOcUDfNYsGs+gpRfmve1tgF6w5PeXD1+N99/Q4nRd/N2XzurhJLcUaioR ZzUXEiACDNqBflAgAA X-Env-Sender: andrew.goodbody@cambrionix.com X-Msg-Ref: server-16.tower-123.messagelabs.com!1464004873!2891702!2 X-Originating-IP: [217.28.138.145] X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked From: Andrew Goodbody To: CC: , , , Andrew Goodbody , Subject: [PATCH V2 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints Date: Mon, 23 May 2016 13:00:43 +0100 Message-ID: <1464004844-26553-2-git-send-email-andrew.goodbody@cambrionix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1464004844-26553-1-git-send-email-andrew.goodbody@cambrionix.com> References: <1464004844-26553-1-git-send-email-andrew.goodbody@cambrionix.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [46.17.166.30] X-ClientProxiedBy: SEHSTE15FE04.hs20.net (172.18.251.44) To SEHSTE15D2BE2.hs20.net (172.18.251.29) X-EXCLAIMER-MD-CONFIG: 266e7a57-cddd-49fd-bdea-19bca6d40303 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx packets being dropped silently. Signed-off-by: Andrew Goodbody Cc: stable@vger.kernel.org --- V2 removed debugging call drivers/usb/musb/musb_host.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 2f8ad7f..2966596 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -594,14 +594,13 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum) musb_writew(ep->regs, MUSB_TXCSR, 0); /* scrub all previous state, clearing toggle */ - } else { - csr = musb_readw(ep->regs, MUSB_RXCSR); - if (csr & MUSB_RXCSR_RXPKTRDY) - WARNING("rx%d, packet/%d ready?\n", ep->epnum, - musb_readw(ep->regs, MUSB_RXCOUNT)); - - musb_h_flush_rxfifo(ep, MUSB_RXCSR_CLRDATATOG); } + csr = musb_readw(ep->regs, MUSB_RXCSR); + if (csr & MUSB_RXCSR_RXPKTRDY) + WARNING("rx%d, packet/%d ready?\n", ep->epnum, + musb_readw(ep->regs, MUSB_RXCOUNT)); + + musb_h_flush_rxfifo(ep, MUSB_RXCSR_CLRDATATOG); /* target addr and (for multipoint) hub addr/port */ if (musb->is_multipoint) { -- 2.7.4