From: Davidlohr Bueso <dave@stgolabs.net>
To: mingo@kernel.org, peterz@infradead.org
Cc: Waiman.Long@hpe.com, dave@stgolabs.net,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: [PATCH] spinlock: Get rid of spin_can_lock()
Date: Mon, 23 May 2016 06:54:02 -0700 [thread overview]
Message-ID: <1464011642-29168-1-git-send-email-dave@stgolabs.net> (raw)
... it has no users and we already have the the regular spin_is_lock()
call anyway -- although iirc this was going to be different
than the simple negation for lock elision implementations. Lets drop it.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
include/linux/spinlock.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index 47dd0cebd204..047c6f6c3268 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -264,12 +264,6 @@ static inline void do_raw_spin_unlock(raw_spinlock_t *lock) __releases(lock)
1 : ({ local_irq_restore(flags); 0; }); \
})
-/**
- * raw_spin_can_lock - would raw_spin_trylock() succeed?
- * @lock: the spinlock in question.
- */
-#define raw_spin_can_lock(lock) (!raw_spin_is_locked(lock))
-
/* Include rwlock functions */
#include <linux/rwlock.h>
@@ -392,11 +386,6 @@ static __always_inline int spin_is_contended(spinlock_t *lock)
return raw_spin_is_contended(&lock->rlock);
}
-static __always_inline int spin_can_lock(spinlock_t *lock)
-{
- return raw_spin_can_lock(&lock->rlock);
-}
-
#define assert_spin_locked(lock) assert_raw_spin_locked(&(lock)->rlock)
/*
--
2.8.2
next reply other threads:[~2016-05-23 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 13:54 Davidlohr Bueso [this message]
2016-05-24 10:21 ` Peter Zijlstra
2016-06-01 12:45 ` Peter Zijlstra
2016-06-06 17:27 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464011642-29168-1-git-send-email-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=Waiman.Long@hpe.com \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®