From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [RFC][PATCH v2 0/5] perf config: Reimplement perf_config() using perf_config_set__inter()
Date: Tue, 24 May 2016 16:17:27 +0900 [thread overview]
Message-ID: <1464074252-21991-1-git-send-email-treeze.taeung@gmail.com> (raw)
Everytime perf_config() is called, perf_config() always read config files.
(i.e. user config '~/.perfconfig' and system config '$(sysconfdir)/perfconfig')
But we need to use 'struct perf_config_set config_set' variable
that already contains all config key-value pairs
to avoid this repetitive work in perf_config().
In other words, if new perf_config() is called,
only first time 'config_set' is initialized
collecting all configs from config files and it work with perf_config_set__iter().
If we do, what old perf_config() handle is the same as new perf_config() work
without the repetitive work that read config files.
IMHO, I think this patchset is needed because not only the repetitive work
should be avoided but also in near future, it would be smooth to manage perf configs.
If you give me any feedback, I'd apprecicated it. :)
Thanks,
Taeung
v2:
- split a patch into several patches
- reimplement show_config() using new perf_config()
- modify perf_config_set__delete using global variable 'config_set'
- reset config set when only 'config' sub-commaned work
because of options for config file location
Taeung Song (5):
perf config: Use new perf_config_set__init() to initialize config set
perf config: Reimplement perf_config() using perf_config_set__iter()
perf config: Modify perf_config_set__delete() using global variable
'config_set'
perf config: Reimplement show_config() using perf_config()
perf config: Reset config set at only 'config' sub-command
tools/perf/builtin-config.c | 43 ++++--------
tools/perf/util/config.c | 156 +++++++++++++++++++++++++++++---------------
tools/perf/util/config.h | 2 +-
3 files changed, 117 insertions(+), 84 deletions(-)
--
2.5.0
next reply other threads:[~2016-05-24 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 7:17 Taeung Song [this message]
2016-05-24 7:17 ` [PATCH v2 1/5] perf config: Use new perf_config_set__init() to initialize config set Taeung Song
2016-05-24 7:17 ` [PATCH v2 2/5] perf config: Reimplement perf_config() using perf_config_set__iter() Taeung Song
2016-05-24 7:17 ` [PATCH v2 3/5] perf config: Modify perf_config_set__delete() using global variable 'config_set' Taeung Song
2016-05-24 7:17 ` [PATCH v2 4/5] perf config: Reimplement show_config() using perf_config() Taeung Song
2016-05-24 7:17 ` [PATCH v2 5/5] perf config: Reset config set at only 'config' sub-command Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464074252-21991-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®