From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbcEXIWy (ORCPT ); Tue, 24 May 2016 04:22:54 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.163]:33044 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbcEXIWu (ORCPT ); Tue, 24 May 2016 04:22:50 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRWlGSWpSXmKPExsVyU6Zrom4ov0u 4wbll7Bb/7yxitWhevJ7N4vKuOWwWi5a1Mlss2PiI0YHVY//cNewex29sZ/L4vEkugDmKNTMv Kb8igTXj48blzAWN3BWbbmY2MO7k7GLk4hASWM8osXv2deYuRk4ONgEziV2v1rGD2CICQhKdO z4wgRQxC6xmlDg7byUbSEJYIETiwacPrCA2i4CqxIolzSwgNq+An8T15dPAbAkBOYmb5zrBhn IK+EvcP3aMEcQWAqrpmLCJHaJeUOLkzCdg9cwCEhIHX7xghqjRlli+p48dYo6CxOxVG5gg7GS JhucnoGxriba/H9gnMArMQjJqFpJRCxiZVjFqFKcWlaUW6Roa6CUVZaZnlOQmZuYAecZ6uanF xYnpqTmJScV6yfm5mxiBAVzPwMC4g3Fbl/MhRkkOJiVR3tXvnMOF+JLyUyozEosz4otKc1KLD zHKcHAoSfDa8LmECwkWpaanVqRl5gBjCSYtwcGjJMJ7lxcozVtckJhbnJkOkTrFqMvxYfL1tU xCLHn5ealS4rxSIDMEQIoySvPgRsDi+hKjrJQwLyMDA4MQT0FqUW5mCar8K0ZxDkYlYV4PkCk 8mXklcJteAR3BBHSE/xdnkCNKEhFSUg2Ma+6wF3YulHf9nHnsYfekC/9cnhZynlwa1h3tFZsV vujTO+WC/lnb1y15+VubaY0Ei1ZKsfXtA4q7lnh5+vIcFEk6n5musGarqueSG1dNBZ5PO5bq8 q5V4Wi513axmU3vObqTFnJsWh5jJ764tf5r+zOWZ9EycmcnVr3WuflsmpP6hbeyb1N1lViKMx INtZiLihMBdVkYkuYCAAA= X-Env-Sender: andrew.goodbody@cambrionix.com X-Msg-Ref: server-3.tower-140.messagelabs.com!1464078164!33365441!2 X-Originating-IP: [217.28.138.145] X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked From: Andrew Goodbody To: CC: , , , Andrew Goodbody , Subject: [PATCH V3 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints Date: Tue, 24 May 2016 09:22:33 +0100 Message-ID: <1464078154-13157-2-git-send-email-andrew.goodbody@cambrionix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1464078154-13157-1-git-send-email-andrew.goodbody@cambrionix.com> References: <1464078154-13157-1-git-send-email-andrew.goodbody@cambrionix.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [46.17.166.30] X-ClientProxiedBy: SEHSTE15FE11.hs20.net (172.18.251.39) To SEHSTE15D2BE2.hs20.net (172.18.251.29) X-EXCLAIMER-MD-CONFIG: 266e7a57-cddd-49fd-bdea-19bca6d40303 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx packets being dropped silently. Signed-off-by: Andrew Goodbody Cc: stable@vger.kernel.org --- V3 no change V2 removed debugging call drivers/usb/musb/musb_host.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index b7a02ce..e5b6aba 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -594,14 +594,13 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum) musb_writew(ep->regs, MUSB_TXCSR, 0); /* scrub all previous state, clearing toggle */ - } else { - csr = musb_readw(ep->regs, MUSB_RXCSR); - if (csr & MUSB_RXCSR_RXPKTRDY) - WARNING("rx%d, packet/%d ready?\n", ep->epnum, - musb_readw(ep->regs, MUSB_RXCOUNT)); - - musb_h_flush_rxfifo(ep, MUSB_RXCSR_CLRDATATOG); } + csr = musb_readw(ep->regs, MUSB_RXCSR); + if (csr & MUSB_RXCSR_RXPKTRDY) + WARNING("rx%d, packet/%d ready?\n", ep->epnum, + musb_readw(ep->regs, MUSB_RXCOUNT)); + + musb_h_flush_rxfifo(ep, MUSB_RXCSR_CLRDATATOG); /* target addr and (for multipoint) hub addr/port */ if (musb->is_multipoint) { -- 2.7.4