From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbcEXKml (ORCPT ); Tue, 24 May 2016 06:42:41 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:41653 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcEXKmk (ORCPT ); Tue, 24 May 2016 06:42:40 -0400 From: Matt Redfearn To: Thomas Gleixner CC: , Matt Redfearn , Subject: [PATCH] genirq: Fix missing return value in irq_destroy_ipi() Date: Tue, 24 May 2016 11:42:30 +0100 Message-ID: <1464086550-24734-1-git-send-email-matt.redfearn@imgtec.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.116] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7cec18a3906b ("genirq: Add error code reporting to irq_{reserve,destroy}_ipi") changed the return type of irq_destroy_ipi to int, but missed adding a value to one return statement. Fix this to silence the resultant compiler warning: kernel/irq/ipi.c In function ‘irq_destroy_ipi’: kernel/irq/ipi.c:128:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type] return; ^ Fixes: 7cec18a3906b ("genirq: Add error code reporting to irq_{reserve,destroy}_ipi") Signed-off-by: Matt Redfearn --- kernel/irq/ipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c index c42742208e5e..89b49f6773f0 100644 --- a/kernel/irq/ipi.c +++ b/kernel/irq/ipi.c @@ -125,7 +125,7 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest) domain = data->domain; if (WARN_ON(domain == NULL)) - return; + return -EINVAL; if (!irq_domain_is_ipi(domain)) { pr_warn("Trying to destroy a non IPI domain!\n"); -- 2.5.0