From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755471AbcEXNah (ORCPT ); Tue, 24 May 2016 09:30:37 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:29982 "EHLO hkmmgate102.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753075AbcEXNag (ORCPT ); Tue, 24 May 2016 09:30:36 -0400 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Tue, 24 May 2016 06:30:33 -0700 From: Laxman Dewangan To: , CC: , , "Laxman Dewangan" Subject: [PATCH] gpio: core: Do not call get_direction in atomic context for sleeping gpio Date: Tue, 24 May 2016 18:48:22 +0530 Message-ID: <1464095903-29145-1-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When adding the gpiochip, the GPIO HW drivers' callback get_direction() get called in atomic context. Some of the GPIO HW drivers can sleep when accessing the register and hence it can create the sleeping call in atomic context. Call get_direction() in non-atomic context from gpiochip_add() if GPIO HW driver is having sleepable callback i.e. chip->can_sleep = 1. Signed-off-by: Laxman Dewangan --- This is found when implementing the get_direction() of max77620 on 20160520 linux-next. drivers/gpio/gpiolib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index d407f904..4d04171 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -636,7 +636,15 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data) * If we have .get_direction, set up the initial * direction flag from the hardware. */ - int dir = chip->get_direction(chip, i); + int dir; + + if (chip->can_sleep) + spin_unlock_irqrestore(&gpio_lock, flags); + + dir = chip->get_direction(chip, i); + + if (chip->can_sleep) + spin_lock_irqsave(&gpio_lock, flags); if (!dir) set_bit(FLAG_IS_OUT, &desc->flags); -- 2.1.4