From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbcEYW0D (ORCPT ); Wed, 25 May 2016 18:26:03 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15192 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbcEYWZK (ORCPT ); Wed, 25 May 2016 18:25:10 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 25 May 2016 15:23:33 -0700 From: Rhyland Klein To: Peter De Schrijver , Thierry Reding CC: Michael Turquette , Stephen Boyd , Alexandre Courbot , , , , Stephen Warren , Rhyland Klein Subject: [PATCH 11/11] clk: tegra: WARN if clk in the init_table has enable Date: Wed, 25 May 2016 18:24:31 -0400 Message-ID: <1464215071-28696-12-git-send-email-rklein@nvidia.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464215071-28696-1-git-send-email-rklein@nvidia.com> References: <1464215071-28696-1-git-send-email-rklein@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Enabling clocks through the init_table mechanism is deprecated. Clocks that need to be enabled early and stay on should be marked as CRITICAL. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c index b2cdd9a235f4..898fe922c742 100644 --- a/drivers/clk/tegra/clk.c +++ b/drivers/clk/tegra/clk.c @@ -262,6 +262,11 @@ void __init tegra_init_from_table(struct tegra_clk_init_table *tbl, WARN_ON(1); } + /* Using the init_table to enable clks at boot is + * deprecated. Clks that need to be enabled through early + * boot, they should be marked as CLK_IS_CRITICAL + */ + WARN_ON_ONCE(tbl->state); if (tbl->state) if (clk_prepare_enable(clk)) { pr_err("%s: Failed to enable %s\n", __func__, -- 1.9.1