From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Reduce git commit description style false positives
Date: Fri, 27 May 2016 14:52:46 -0700 [thread overview]
Message-ID: <1464385966.20401.0.camel@perches.com> (raw)
In-Reply-To: <20160527145036.6305b029d27b55f2396e976b@linux-foundation.org>
On Fri, 2016-05-27 at 14:50 -0700, Andrew Morton wrote:
> On Fri, 27 May 2016 14:20:42 -0700 Joe Perches <joe@perches.com>
> wrote:
>
> >
> > Some lines in a commit log appear to be commit SHA1 ids like:
> >
> > ERROR: Please use git commit description style 'commit <12+ chars of
> > sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit
> > description")'
> > Link: http://lkml.kernel.org/r/40e03fd7aaf1f55c75d787128d6d17c5a7122
> > 6c2.1464358556.git.vdavydov@virtuozzo.com
> >
> > Reduce the false positives.
> >
> hm, I still get the falsie when checking this very patch.
because commit 0123456789ab doesn't exist
prev parent reply other threads:[~2016-05-27 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160527134341.220d15e6cae99e17f2cbc879@linux-foundation.org>
2016-05-27 21:20 ` Joe Perches
2016-05-27 21:50 ` Andrew Morton
2016-05-27 21:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464385966.20401.0.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®