mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: He Kuang <hekuang@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
	<wangnan0@huawei.com>, <hekuang@huawei.com>,
	<jpoimboe@redhat.com>, <ak@linux.intel.com>, <eranian@google.com>,
	<namhyung@kernel.org>, <adrian.hunter@intel.com>,
	<sukadev@linux.vnet.ibm.com>, <masami.hiramatsu.pt@hitachi.com>,
	<tumanova@linux.vnet.ibm.com>, <kan.liang@intel.com>,
	<penberg@kernel.org>, <dsahern@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 04/11] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map
Date: Sat, 28 May 2016 11:59:53 +0000	[thread overview]
Message-ID: <1464436800-39860-5-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <1464436800-39860-1-git-send-email-hekuang@huawei.com>

For determine the libunwind methods to use, we should get the
32bit/64bit information from maps of a thread. When a thread is newly
created, the information is not prepared. This patch moves
unwind__prepare_access() into thread__insert_map() so we can get the
information we need from maps.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/thread.c           | 7 ++-----
 tools/perf/util/unwind-libunwind.c | 7 +++----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 6d3900c..045477d 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -43,11 +43,6 @@ struct thread *thread__new(pid_t pid, pid_t tid)
 		thread->cpu = -1;
 		INIT_LIST_HEAD(&thread->comm_list);
 
-		register_local_unwind_libunwind_ops(thread);
-
-		if (unwind__prepare_access(thread) < 0)
-			goto err_thread;
-
 		comm_str = malloc(32);
 		if (!comm_str)
 			goto err_thread;
@@ -207,6 +202,8 @@ void thread__insert_map(struct thread *thread, struct map *map)
 {
 	map_groups__fixup_overlappings(thread->mg, map, stderr);
 	map_groups__insert(thread->mg, map);
+
+	unwind__prepare_access(thread);
 }
 
 static int thread__clone_map_groups(struct thread *thread,
diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
index 0277b22..93d2d8e 100644
--- a/tools/perf/util/unwind-libunwind.c
+++ b/tools/perf/util/unwind-libunwind.c
@@ -695,10 +695,9 @@ void register_local_unwind_libunwind_ops(struct thread *thread)
 
 int unwind__prepare_access(struct thread *thread)
 {
-	if (thread->unwind_libunwind_ops)
-		return thread->unwind_libunwind_ops->prepare_access(thread);
-	else
-		return 0;
+	register_local_unwind_libunwind_ops(thread);
+
+	return thread->unwind_libunwind_ops->prepare_access(thread);
 }
 
 void unwind__flush_access(struct thread *thread)
-- 
1.8.5.2

  parent reply	other threads:[~2016-05-28 12:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28 11:59 [PATCH v6 00/11] Add support for remote unwind He Kuang
2016-05-28 11:59 ` [PATCH v6 01/11] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-05-28 11:59 ` [PATCH v6 02/11] perf tools: Decouple thread->address_space on libunwind He Kuang
2016-05-28 11:59 ` [PATCH v6 03/11] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang
2016-05-30  8:53   ` Jiri Olsa
2016-05-28 11:59 ` He Kuang [this message]
2016-05-30  8:52   ` [PATCH v6 04/11] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map Jiri Olsa
2016-05-28 11:59 ` [PATCH v6 05/11] perf tools: Separate local/remote libunwind config He Kuang
2016-05-30  8:52   ` Jiri Olsa
2016-05-28 11:59 ` [PATCH v6 06/11] perf tools: Extract local libunwind code out of unwind-libunwind.c He Kuang
2016-05-28 12:10   ` Wangnan (F)
2016-05-30  3:22     ` [PATCH v6 06/11 1 update 1/2] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang
2016-05-30  3:22       ` [PATCH v6 06/11 1 update 2/2] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang
2016-05-30  3:24     ` [PATCH v6 06/11] perf tools: Extract local libunwind code out of unwind-libunwind.c Hekuang
2016-05-28 11:59 ` [PATCH v6 07/11] perf tools: Export normalize_arch() function He Kuang
2016-05-28 11:59 ` [PATCH v6 08/11] perf tools: Show warnings for unsupported cross-platform unwind He Kuang
2016-05-30  8:53   ` Jiri Olsa
2016-05-28 11:59 ` [PATCH v6 09/11] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang
2016-05-28 11:59 ` [PATCH v6 10/11] perf callchain: Support x86 target platform He Kuang
2016-05-30  8:52   ` Jiri Olsa
2016-05-30  8:53   ` Jiri Olsa
2016-05-30  8:53   ` Jiri Olsa
2016-05-30  9:11     ` Hekuang
2016-05-30  9:30       ` Jiri Olsa
2016-05-30 10:58         ` Hekuang
2016-05-30 14:24           ` Jiri Olsa
2016-05-28 12:00 ` [PATCH v6 11/11] perf callchain: Support aarch64 cross-platform He Kuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464436800-39860-5-git-send-email-hekuang@huawei.com \
    --to=hekuang@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tumanova@linux.vnet.ibm.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®