From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932704AbcE3HkY (ORCPT ); Mon, 30 May 2016 03:40:24 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60146 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932623AbcE3HkV (ORCPT ); Mon, 30 May 2016 03:40:21 -0400 X-AuditID: cbfee68e-f79b26d0000013da-ac-574bee5d9091 From: Jaehoon Chung To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ulf.hansson@linaro.org, arnd@arndb.de, a.hajda@samsung.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, k.kozlowski@samsung.com, Jaehoon Chung Subject: [PATCH] mmc: core: fix the wrong error control Date: Mon, 30 May 2016 16:40:14 +0900 Message-id: <1464594014-31934-1-git-send-email-jh80.chung@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsWyRsSkSDf2nXe4wYNlGha31p1jtZizfg2b xd9Jx9gtbvxqY7V4/cLQ4vKuOWwWR/73M1o86nvLbnF8bbgDp8fvX5MYPe5c28PmcWLGbxaP vi2rGD0+b5ILYI3isklJzcksSy3St0vgytj0Yw17QTtXxewpq9gaGFs4uhg5OSQETCQ6F/9l g7DFJC7cWw9kc3EICaxglPjb28AGU7R3zQGoxCxGid3bJ7NCOD8YJa7O+ApWxSagI7H923Em EFtEwFri+vc7zCBFzAJ7GSUunm8CSwgLmEu03JzGDGKzCKhKLL7UyQpi8wq4STw8dIYFYp2c xMljEBskBPrZJWZsa2aFaBCQ+Db5EFARB1BCVmLTAWaIekmJgytusExgFFzAyLCKUTS1ILmg OCm9yEivODG3uDQvXS85P3cTIzCUT/971reD8eYB60OMAhyMSjy8CWne4UKsiWXFlbmHGE2B NkxklhJNzgdGTF5JvKGxmZGFqYmpsZG5pZmSOG+C1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xM HJxSDYyrznuu65qVOjlnk8s5y/VTf5x6sEr+gzC/GL+kqYb3prKa9te7Zq25tbMx+/zme22J k0yPT3xr9swroGaCkbC06T6tVRe5j0hqXHT9uWrfPRem6E+PJFY5/Wax+NgYLxkZOpdn9oln sr+OvCl0exvZJzup572pabq6lVzi8aV77WqnaHHaRW1SYinOSDTUYi4qTgQAc8Uhy2ACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t9jQd3Yd97hBp8+KFncWneO1WLO+jVs Fn8nHWO3uPGrjdXi9QtDi8u75rBZHPnfz2jxqO8tu8XxteEOnB6/f01i9LhzbQ+bx4kZv1k8 +rasYvT4vEkugDWqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJ xSdA1y0zB+geJYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPGph9r2Ava uSpmT1nF1sDYwtHFyMkhIWAisXfNATYIW0ziwr31QDYXh5DALEaJ3dsns0I4Pxglrs74ClbF JqAjsf3bcSYQW0TAWuL69zvMIEXMAnsZJS6ebwJLCAuYS7TcnMYMYrMIqEosvtTJCmLzCrhJ PDx0hgVinZzEyWOTWScwci9gZFjFKJFakFxQnJSea5iXWq5XnJhbXJqXrpecn7uJERwvz6R2 MB7c5X6IUYCDUYmHt0DTO1yINbGsuDL3EKMEB7OSCO/bx0Ah3pTEyqrUovz4otKc1OJDjKZA B0xklhJNzgfGcl5JvKGxiZmRpZG5oYWRsbmSOO/j/+vChATSE0tSs1NTC1KLYPqYODilGhgV eMpvPqmcGyscfWiFx8HgRRURkfozuQ9sV7v/L4Cx4LOHyrFrmbHZZmH3rU/rH9fsWjLF3zj/ VZujOUfiYs0fvsYrj6iz2R1UndmSP+2GxZuz/yfs8ux8uIcpOIVzbuvpH/NfP11QukrU/GPs y/lf7Weu8xDOn6mS6bmZ5eVpW/bIp6dFeRiVWIozEg21mIuKEwGFrp0+rQIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After applied "remove lots of IS_ERR_VALUE abuses", it shoold be misoperation. (commit 287980e49) If mmc_bus_test is successful, it returned the bus-witdh bit. The below log is error log [ 2.542260] mmc0: mmc_select_hs200 failed, error 3 [ 2.542275] mmc0: error 3 whilst initialising MMC card Signed-off-by: Jaehoon Chung --- drivers/mmc/core/mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index c984321..aafb73d 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card) * switch to HS200 mode if bus width is set successfully. */ err = mmc_select_bus_width(card); - if (!err) { + if (err > 0) { val = EXT_CSD_TIMING_HS200 | card->drive_strength << EXT_CSD_DRV_STR_SHIFT; err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, } else if (mmc_card_hs(card)) { /* Select the desired bus width optionally */ err = mmc_select_bus_width(card); - if (!err) { + if (err > 0) { err = mmc_select_hs_ddr(card); if (err) goto free_card; -- 1.9.1