From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755059AbcE3Okt (ORCPT ); Mon, 30 May 2016 10:40:49 -0400 Received: from mga02.intel.com ([134.134.136.20]:11354 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbcE3Okr (ORCPT ); Mon, 30 May 2016 10:40:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,390,1459839600"; d="scan'208";a="991610803" From: Andy Shevchenko To: Linus Torvalds , Kui Zhang , Darren Hart , Andrew Morton , Linux Kernel Mailing List , =?UTF-8?q?Bj=C3=B8rn=20Mork?= Cc: Andy Shevchenko Subject: [PATCH v1 2/2] lib/uuid.c: use correct offset in uuid parser Date: Mon, 30 May 2016 17:40:42 +0300 Message-Id: <1464619242-32341-2-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1464619242-32341-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1464619242-32341-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjørn Mork Use '+ 0' and '+ 1' as offsets, like they were intended, instead of adding to the result. Fixes: 2b1b0d66704a ("lib/uuid.c: introduce a few more generic helpers") Signed-off-by: Bjørn Mork Signed-off-by: Andy Shevchenko --- lib/uuid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/uuid.c b/lib/uuid.c index e116ae5..37687af 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -106,8 +106,8 @@ static int __uuid_to_bin(const char *uuid, __u8 b[16], const u8 ei[16]) return -EINVAL; for (i = 0; i < 16; i++) { - int hi = hex_to_bin(uuid[si[i]] + 0); - int lo = hex_to_bin(uuid[si[i]] + 1); + int hi = hex_to_bin(uuid[si[i] + 0]); + int lo = hex_to_bin(uuid[si[i] + 1]); b[ei[i]] = (hi << 4) | lo; } -- 2.8.1