From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162213AbcEaGdv (ORCPT ); Tue, 31 May 2016 02:33:51 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36142 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162141AbcEaGca (ORCPT ); Tue, 31 May 2016 02:32:30 -0400 From: Eduardo Valentin To: Rui Zhang Cc: Linux PM , LKML , Eduardo Valentin Subject: [PATCH 13/15] thermal: sysfs: lock cdev while accessing cur_state Date: Mon, 30 May 2016 23:31:34 -0700 Message-Id: <1464676296-5610-14-git-send-email-edubezval@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1464676296-5610-1-git-send-email-edubezval@gmail.com> References: <1464676296-5610-1-git-send-email-edubezval@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Serialized calls to cdev->ops in user facing sysfs handlers thermal_cooling_device_cur_state_show() and thermal_cooling_device_cur_state_store(). Cc: Zhang Rui Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- drivers/thermal/thermal_sysfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c index 3eaa081..ab78e08 100644 --- a/drivers/thermal/thermal_sysfs.c +++ b/drivers/thermal/thermal_sysfs.c @@ -715,7 +715,9 @@ thermal_cooling_device_cur_state_show(struct device *dev, unsigned long state; int ret; + mutex_lock(&cdev->lock); ret = cdev->ops->get_cur_state(cdev, &state); + mutex_unlock(&cdev->lock); if (ret) return ret; return sprintf(buf, "%ld\n", state); @@ -736,7 +738,9 @@ thermal_cooling_device_cur_state_store(struct device *dev, if ((long)state < 0) return -EINVAL; + mutex_lock(&cdev->lock); result = cdev->ops->set_cur_state(cdev, state); + mutex_unlock(&cdev->lock); if (result) return result; return count; -- 2.1.4