mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org,
	"Daniel Stone" <daniels@collabora.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Rob Clark" <robdclark@gmail.com>,
	"Greg Hackmann" <ghackmann@google.com>,
	"John Harrison" <John.C.Harrison@Intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>
Subject: [PATCH 08/18] staging/android: remove size arg of sync_timeline_create()
Date: Tue, 31 May 2016 16:59:03 -0300	[thread overview]
Message-ID: <1464724753-2490-9-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1464724753-2490-1-git-send-email-gustavo@padovan.org>

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

After we removed sw_sync_timeline this arg has not been really used by
anyone, all its users pass the size of struct sync_timeline there.

So simplify this function but not requiring the size anymore.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/staging/android/sync.c       | 7 ++-----
 drivers/staging/android/sync.h       | 7 ++-----
 drivers/staging/android/sync_debug.c | 2 +-
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index 442d808..c83a599 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -30,15 +30,12 @@
 
 static const struct fence_ops timeline_fence_ops;
 
-struct sync_timeline *sync_timeline_create(int size, const char *drv_name,
+struct sync_timeline *sync_timeline_create(const char *drv_name,
 					   const char *name)
 {
 	struct sync_timeline *obj;
 
-	if (size < sizeof(struct sync_timeline))
-		return NULL;
-
-	obj = kzalloc(size, GFP_KERNEL);
+	obj = kzalloc(sizeof(*obj), GFP_KERNEL);
 	if (!obj)
 		return NULL;
 
diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
index f003e97..f2fbf98 100644
--- a/drivers/staging/android/sync.h
+++ b/drivers/staging/android/sync.h
@@ -66,16 +66,13 @@ static inline struct sync_timeline *fence_parent(struct fence *fence)
 
 /**
  * sync_timeline_create() - creates a sync object
- * @size:	size to allocate for this obj
  * @drv_name:	sync_timeline driver name
  * @name:	sync_timeline name
  *
- * Creates a new sync_timeline. @size bytes will be allocated allowing
- * for implementation specific data to be kept after the generic
- * sync_timeline struct. Returns the sync_timeline object or NULL in
+ * Creates a new sync_timeline. Returns the sync_timeline object or NULL in
  * case of error.
  */
-struct sync_timeline *sync_timeline_create(int size, const char *drv_name,
+struct sync_timeline *sync_timeline_create(const char *drv_name,
 					   const char *name);
 
 /**
diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c
index 6282046..cb0f888 100644
--- a/drivers/staging/android/sync_debug.c
+++ b/drivers/staging/android/sync_debug.c
@@ -218,7 +218,7 @@ static int sw_sync_debugfs_open(struct inode *inode, struct file *file)
 
 	get_task_comm(task_comm, current);
 
-	obj = sync_timeline_create(sizeof(*obj), "sw_sync", task_comm);
+	obj = sync_timeline_create("sw_sync", task_comm);
 	if (!obj)
 		return -ENOMEM;
 
-- 
2.5.5

  parent reply	other threads:[~2016-05-31 20:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 19:58 [PATCH 00/18] staging/android: clean up SW_SYNC Gustavo Padovan
2016-05-31 19:58 ` [PATCH 01/18] staging/android: store last signaled value on sync timeline Gustavo Padovan
2016-05-31 19:58 ` [PATCH 02/18] staging/android: remove .{fence,timeline}_value_str() from timeline_ops Gustavo Padovan
2016-05-31 19:58 ` [PATCH 03/18] staging/android: remove struct sync_timeline_ops Gustavo Padovan
2016-05-31 19:58 ` [PATCH 04/18] staging/android: remove sw_sync_timeline and sw_sync_pt Gustavo Padovan
2016-05-31 19:59 ` [PATCH 05/18] staging/android: remove sw_sync.[ch] files Gustavo Padovan
2016-05-31 19:59 ` [PATCH 06/18] staging/android: rename android_fence to timeline_fence Gustavo Padovan
2016-05-31 19:59 ` [PATCH 07/18] staging/android: remove unnecessary check for fence Gustavo Padovan
2016-05-31 19:59 ` Gustavo Padovan [this message]
2016-05-31 19:59 ` [PATCH 09/18] staging/android: bring struct sync_pt back Gustavo Padovan
2016-05-31 19:59 ` [PATCH 10/18] staging/android: move sw_sync related code to sw_sync.c Gustavo Padovan
2016-05-31 19:59 ` [PATCH 11/18] staging/android: clean up #includes in the sync framework Gustavo Padovan
2016-05-31 19:59 ` [PATCH 12/18] staging/android: make sync_timeline internal to sw_sync Gustavo Padovan
2016-05-31 19:59 ` [PATCH 13/18] staging/android: make sw_ioctl info internal to sw_sync.c Gustavo Padovan
2016-05-31 19:59 ` [PATCH 14/18] staging/android: remove 'destroyed' member from struct sync_timeline Gustavo Padovan
2016-05-31 19:59 ` [PATCH 15/18] staging/android: remove sync_timeline_destroy() Gustavo Padovan
2016-05-31 19:59 ` [PATCH 16/18] staging/android: remove drv_name from sync_timeline Gustavo Padovan
2016-05-31 19:59 ` [PATCH 17/18] staging/android: rename sync.h to sync_debug.h Gustavo Padovan
2016-05-31 19:59 ` [PATCH 18/18] staging/android: add DEBUG_FS dependence on Kconfig Gustavo Padovan
2016-06-08 19:07 ` [PATCH 00/18] staging/android: clean up SW_SYNC Gustavo Padovan
2016-06-09  5:45   ` Greg Kroah-Hartman
2016-06-09  8:23     ` Daniel Vetter
2016-06-09 13:56       ` Sumit Semwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464724753-2490-9-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=John.C.Harrison@Intel.com \
    --cc=arve@android.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=riandrews@android.com \
    --cc=robdclark@gmail.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®