From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbcEaVI2 (ORCPT ); Tue, 31 May 2016 17:08:28 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53388 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756457AbcEaVI0 (ORCPT ); Tue, 31 May 2016 17:08:26 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, knaack.h@gmx.de, lars@metafoo.de, jic23@kernel.org, ciorneiioana@gmail.com, janani.rvchndrn@gmail.com, afd@ti.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, Luis de Bethencourt Subject: [PATCH 2/2] staging: iio: accel: add error check Date: Tue, 31 May 2016 22:08:04 +0100 Message-Id: <1464728884-29686-2-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1464728884-29686-1-git-send-email-luisbg@osg.samsung.com> References: <1464728884-29686-1-git-send-email-luisbg@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Go to error_ret if sca3000_read_ctrl_reg() failed. Signed-off-by: Luis de Bethencourt --- Noticed this while inspecting the code for the 1/2 patch. Thanks, Luis drivers/staging/iio/accel/sca3000_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index ec12181..b3f6dbf 100644 --- a/drivers/staging/iio/accel/sca3000_core.c +++ b/drivers/staging/iio/accel/sca3000_core.c @@ -1046,6 +1046,8 @@ static int sca3000_clean_setup(struct sca3000_state *st) /* Disable ring buffer */ ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); + if (ret < 0) + goto error_ret; ret = sca3000_write_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL, (ret & SCA3000_OUT_CTRL_PROT_MASK) | SCA3000_OUT_CTRL_BUF_X_EN -- 2.5.1