From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757346AbcFAC2M (ORCPT ); Tue, 31 May 2016 22:28:12 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.10]:23311 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757309AbcFAC2H (ORCPT ); Tue, 31 May 2016 22:28:07 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRWlGSWpSXmKPExsVywNY2U9fUwy/ coGM/q8XCtiUsFpd3zWFzYPL4vEkugDGKNTMvKb8igTXj9YvZ7AV3eSvuvZ3P1sB4k7uLkYtD SGA3o8T+6z/YIZzDjBLNc48wwTk3bv6EylxmlNjRsQkqs45Rov/RMlYIZwujxNonVxm7GDk52 AQMJGbeucsOYosInGeReHort4uRg0NYwFvi2FJnEJNFQFXiRF8QSAWvgKfE5nNzmEFsCQE5iZ PHJrOC2JwCXhJbJ78HmygEVNP88B+UrSZx+OwjNoj6YImenWvZIOYISpyc+YQFxGYWkJA4+OI F8wRGoVlIUrOQpBYwMq1iVC9OLSpLLdI100sqykzPKMlNzMzRNTQ00stNLS5OTE/NSUwq1kvO z93ECAxhBiDYwfh/gvMhRkkOJiVR3h8ufuFCfEn5KZUZicUZ8UWlOanFhxhlODiUJHiZ3IFyg kWp6akVaZk5wGiCSUtw8CiJ8DqDpHmLCxJzizPTIVKnGBWlxHlZQBICIImM0jy4NlgEX2KUlR LmZQQ6RIinILUoN7MEVf4VozgHo5IwryXIFJ7MvBK46a+AFjMBLY7P8AFZXJKIkJJqYLTb2tj y4Nvc3umWtlVdRw16UzhvlKtmKbzmb/p1eprj/9JLbV+LjunJ7JJPWWnHy/YxtPUZ942KvQk9 DtfcfR0PBXA2eYjLvq98tWN/puHnKxxHkiS/F9YtPOD3dva+uat/VHsmyibXPS2uepx0SPfA5 aXBkjpzdmqc+nBld9uxneus1lz0iFdiKc5INNRiLipOBACEsrLv2wIAAA== X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-13.tower-28.messagelabs.com!1464748082!18692585!7 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 01/27] staging: unisys: visorbus change -1 return values Date: Tue, 31 May 2016 22:26:27 -0400 Message-ID: <1464748013-31309-2-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> References: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 01 Jun 2016 02:27:03.0521 (UTC) FILETIME=[1584B510:01D1BBAD] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Arfvidson This patch changes the vague -1 return values to -EFAULT since it would be the most appropriate, given that this error would only occur in an unexpected bad offset field. Resulting in a bad address. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c index 3a147db..d32b898 100644 --- a/drivers/staging/unisys/visorbus/visorbus_main.c +++ b/drivers/staging/unisys/visorbus/visorbus_main.c @@ -876,10 +876,10 @@ write_vbus_chp_info(struct visorchannel *chan, int off = sizeof(struct channel_header) + hdr_info->chp_info_offset; if (hdr_info->chp_info_offset == 0) - return -1; + return -EFAULT; if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -1; + return -EFAULT; return 0; } @@ -895,10 +895,10 @@ write_vbus_bus_info(struct visorchannel *chan, int off = sizeof(struct channel_header) + hdr_info->bus_info_offset; if (hdr_info->bus_info_offset == 0) - return -1; + return -EFAULT; if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -1; + return -EFAULT; return 0; } @@ -915,10 +915,10 @@ write_vbus_dev_info(struct visorchannel *chan, (hdr_info->device_info_struct_bytes * devix); if (hdr_info->dev_info_offset == 0) - return -1; + return -EFAULT; if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -1; + return -EFAULT; return 0; } -- 1.9.1