From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161028AbcFACbH (ORCPT ); Tue, 31 May 2016 22:31:07 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.16]:52072 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757333AbcFAC2L (ORCPT ); Tue, 31 May 2016 22:28:11 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRWlGSWpSXmKPExsVywNY2U9fCwy/ cYOdPIYuFbUtYLC7vmsPmwOTxeZNcAGMUa2ZeUn5FAmvG+yVLGQtOcFd823iIrYGxn6uLkYtD SGA3o8SDHR0sEM5hRonmuUeY4JwbN3+yQziXGSV+P29gg3DWMUr0P1rGCuFsYZRoe3QHqIyTg 03AQGLmnbtgtojAeRaJp7dyuxg5OIQFgiTObWYHMVkEVCUWXGIGMXkFPCUWXskEKZYQkJM4eW wyK4jNKeAlsXXye0YQWwiopPnhPyhbTeLw2UdsEPXBEg+/b2cBsXkFBCVOznwCZjMLSEgcfPG CeQKj0CwkqVlIUgsYmVYxqhenFpWlFuka6yUVZaZnlOQmZuboGhoa6eWmFhcnpqfmJCYV6yXn 525iBAYwAxDsYLzf53yIUZKDSUmU94eLX7gQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd4cd6CcY FFqempFWmYOMJZg0hIcPEoivM4gad7igsTc4sx0iNQpRkUpcV4WkIQASCKjNA+uDRa/lxhlpY R5GYEOEeIpSC3KzSxBlX/FKM7BqCTM+98NaApPZl4J3PRXQIuZgBbHZ/iALC5JREhJNTC21oa +2MmnFKWu9tRpXu3RzOjrF9/xTb61e6NoNOMvs+Udk1x5X52cJLyw1Nrk6CrpDyunfE1r+hje 6NB7aY6R1i7r3oPP923gX6fU/OHi84UpnxTFGs8IiK37Eu92oiOpR/daE1OKzqKK1TVGS/w7F ZJ0vEpvBXzVs/dyeBN4TnerUKFzx0IlluKMREMt5qLiRACI851s2gIAAA== X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-12.tower-29.messagelabs.com!1464748087!30201412!2 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values Date: Tue, 31 May 2016 22:26:29 -0400 Message-ID: <1464748013-31309-4-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> References: <1464748013-31309-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 01 Jun 2016 02:27:03.0724 (UTC) FILETIME=[15A3AEC0:01D1BBAD] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/iovmcall_gnuc.h b/drivers/staging/unisys/visorbus/iovmcall_gnuc.h index b08b6ec..98ea7f3 100644 --- a/drivers/staging/unisys/visorbus/iovmcall_gnuc.h +++ b/drivers/staging/unisys/visorbus/iovmcall_gnuc.h @@ -22,7 +22,7 @@ __unisys_vmcall_gnuc(unsigned long tuple, unsigned long reg_ebx, cpuid(0x00000001, &cpuid_eax, &cpuid_ebx, &cpuid_ecx, &cpuid_edx); if (!(cpuid_ecx & 0x80000000)) - return -1; + return -EPERM; __asm__ __volatile__(".byte 0x00f, 0x001, 0x0c1" : "=a"(result) : "a"(tuple), "b"(reg_ebx), "c"(reg_ecx)); @@ -40,7 +40,7 @@ __unisys_extended_vmcall_gnuc(unsigned long long tuple, cpuid(0x00000001, &cpuid_eax, &cpuid_ebx, &cpuid_ecx, &cpuid_edx); if (!(cpuid_ecx & 0x80000000)) - return -1; + return -EPERM; __asm__ __volatile__(".byte 0x00f, 0x001, 0x0c1" : "=a"(result) : "a"(tuple), "b"(reg_ebx), "c"(reg_ecx), "d"(reg_edx)); -- 1.9.1