From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250AbcFADMg (ORCPT ); Tue, 31 May 2016 23:12:36 -0400 Received: from ozlabs.org ([103.22.144.67]:43851 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbcFADMf (ORCPT ); Tue, 31 May 2016 23:12:35 -0400 Message-ID: <1464750753.19731.2.camel@ellerman.id.au> Subject: Re: [PATCH v4 09/10] cpuidle/powernv: Add support for POWER ISA v3 idle states From: Michael Ellerman To: Shreyas B Prabhu , Daniel Lezcano Cc: linuxppc-dev@lists.ozlabs.org, paulus@ozlabs.org, linux-kernel@vger.kernel.org, mikey@neuling.org, ego@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Rob Herring , Lorenzo Pieralisi Date: Wed, 01 Jun 2016 13:12:33 +1000 In-Reply-To: <201605311351.u4VDn1i7019941@mx0a-001b2d01.pphosted.com> References: <1464095714-48772-1-git-send-email-shreyas@linux.vnet.ibm.com> <1464095714-48772-10-git-send-email-shreyas@linux.vnet.ibm.com> <574C4DA4.4050100@linaro.org> <201605311351.u4VDn1i7019941@mx0a-001b2d01.pphosted.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-31 at 19:20 +0530, Shreyas B Prabhu wrote: > On 05/30/2016 07:56 PM, Daniel Lezcano wrote: > > On 05/24/2016 03:15 PM, Shreyas B. Prabhu wrote: > > > + psscr_val = kcalloc(dt_idle_states, sizeof(*psscr_val), > > > + GFP_KERNEL); > > > + rc = of_property_read_u64_array(power_mgt, > > > + "ibm,cpu-idle-state-psscr", psscr_val, dt_idle_states); > > > > [cc'ed Lorenzo and Rob ] > > > > I don't see the documentation for the binding. Wouldn't make sense to > > add the value per idle state instead of an index based array ? The binding *should* be documented here AFAIK: https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/power-mgt.txt cheers