From: Yuyang Du <yuyang.du@intel.com>
To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com,
morten.rasmussen@arm.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, Yuyang Du <yuyang.du@intel.com>
Subject: [PATCH v3 5/5] sched/fair: Add inline to detach_entity_load_evg()
Date: Wed, 1 Jun 2016 11:41:06 +0800 [thread overview]
Message-ID: <1464752466-3494-6-git-send-email-yuyang.du@intel.com> (raw)
In-Reply-To: <1464752466-3494-1-git-send-email-yuyang.du@intel.com>
detach_entity_load_evg() is only called by detach_task_cfs_rq(), so
explicitly add inline attribute to it.
Signed-off-by: Yuyang Du <yuyang.du@intel.com>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index eb9041c..77428c4 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2967,7 +2967,8 @@ static inline void attach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_en
cfs_rq_util_change(cfs_rq);
}
-static void detach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
+/* Catch up with the cfs_rq and remove our load when we leave */
+static inline void detach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
{
__update_load_avg(cfs_rq->avg.last_update_time, cpu_of(rq_of(cfs_rq)),
&se->avg, se->on_rq * scale_load_down(se->load.weight),
@@ -8370,7 +8371,6 @@ static void detach_task_cfs_rq(struct task_struct *p)
se->vruntime -= cfs_rq->min_vruntime;
}
- /* Catch up with the cfs_rq and remove our load when we leave */
detach_entity_load_avg(cfs_rq, se);
}
--
1.7.9.5
prev parent reply other threads:[~2016-06-01 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 3:41 [PATCH v3 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du
2016-06-01 3:41 ` [PATCH v3 1/5] sched/fair: Clean up attach_entity_load_avg() Yuyang Du
2016-06-01 3:41 ` [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du
2016-06-01 12:20 ` Vincent Guittot
2016-06-01 19:21 ` Yuyang Du
2016-06-02 7:29 ` Vincent Guittot
2016-06-01 23:41 ` Yuyang Du
2016-06-02 7:40 ` Vincent Guittot
2016-06-01 23:50 ` Yuyang Du
2016-06-01 3:41 ` [PATCH v3 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups Yuyang Du
2016-06-01 3:41 ` [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du
2016-06-01 12:24 ` Vincent Guittot
2016-06-01 18:58 ` Yuyang Du
2016-06-01 3:41 ` Yuyang Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464752466-3494-6-git-send-email-yuyang.du@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®