From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757913AbcFAJyi (ORCPT ); Wed, 1 Jun 2016 05:54:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:38543 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbcFAJya (ORCPT ); Wed, 1 Jun 2016 05:54:30 -0400 X-AuditID: cbfec7f4-f796c6d000001486-30-574eb0d39c00 From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , MyungJoo Ham , Chanwoo Choi , Dmitry Torokhov , Richard Purdie , Jacek Anaszewski , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, rtc-linux@googlegroups.com Cc: r.baldyga@hackerion.com, Bartlomiej Zolnierkiewicz Subject: [PATCH v7 5/6] rtc: max8997: Check for ERRNO of regmap_irq_get_virq() Date: Wed, 01 Jun 2016 11:54:00 +0200 Message-id: <1464774841-1439-5-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1464774841-1439-1-git-send-email-k.kozlowski@samsung.com> References: <1464774841-1439-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1464773339-756-1-git-send-email-k.kozlowski@samsung.com> References: <1464773339-756-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWRbUhTYRiGfXd2zs6Gw+OyelOSuRBDyBoavJhUFNUhUAMLQX/Y1MMU3bQd lQwi/WFNQUtFNmS6aoZrVuo01G0kOV2YVpOpFX5RahNMht+atHJa/677eS6e+8dDYiIDN5jM VhYwKqUsV0IIuEPed6MnXG0JyaeGK3HUNDLGQ+pxAwe1a1txVPdtjkCf19w4qpnzYEjf/xFH 9qcLAFU/r8VQ5ZgboMUFKXo4u4ihmfUBgDZG1Rxknh3H0deVDRy5LDoCvf75CqDVyn6AtJ/e cNBEqZFAU94VgKyWeRz1lqsBGrIWnD9Cz5lHAN1TP8WjbdWDBN3f4yDoDmMkbTaVE/TkuG03 Nd2jbfotnK7qNAFa07jNoVfNodf8UwRxmUxudhGjOnn2piBr8E8Jnm8jbjfu6EEJ6MIrAJ+E VAz8srL+jw9B53QrUQEEpIh6BmDXgzF8P5RyoGnJyfNZBBUNO5qb9qwgapmALs8PUAFIEqOS 4HYd8DkHqAT4wdOJ+ZhLhcNug2VvLqQuQ43LDvbbQuGgo3avmU9dgTO6ScLHol2n2d3L8Z3k 7/L2MOlDEXUJbhoFj0DAY+BnAgeZwox8Nl2ukEaxMgVbqJRHZeQpzGD/dWvdwOCI7QMUCST+ QvFIfLIIlxWxxYo+AElMEiTUmRKSRcJMWfEdRpWXpirMZdg+EEJyJYeFDRbPdREllxUwOQyT z6j+bzkkP7gEJLlgTUNVtLQ94oWmjO1y7TgXJTtP4hO33JpjLb/SG9OOls5PtKUuW7PfvqxK SZUev6slwk/by8SBbLpkur7d5XAZb7X+tluNbbqrHRHeG/PlYrYlLDFIHBJWM6DPsMckKnnT AbE579ei1dqlC36CjUDvxTjnpvx7hOr+mXMSLpslk0ZiKlb2F3r2V6S2AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The regmap_irq_get_virq() can return zero or negative ERRNO, so it is insufficient to check only for non-zero value. Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni --- drivers/rtc/rtc-max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c index 4998aee0f07f..1a06e17ebe9b 100644 --- a/drivers/rtc/rtc-max8997.c +++ b/drivers/rtc/rtc-max8997.c @@ -497,7 +497,7 @@ static int max8997_rtc_probe(struct platform_device *pdev) } virq = regmap_irq_get_virq(max8997->irq_data, MAX8997_PMICIRQ_RTCA1); - if (!virq) { + if (virq <= 0) { dev_err(&pdev->dev, "Failed to create mapping alarm IRQ\n"); ret = -ENXIO; goto err_out; -- 1.9.1