From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030235AbcFBUKU (ORCPT ); Thu, 2 Jun 2016 16:10:20 -0400 Received: from smtprelay0169.hostedemail.com ([216.40.44.169]:34750 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030220AbcFBUKS (ORCPT ); Thu, 2 Jun 2016 16:10:18 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:2899:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:7514:8660:9010:10004:10400:10848:11026:11232:11658:11783:11889:11914:12043:12296:12517:12519:12740:13069:13148:13230:13311:13357:13439:13894:14181:14659:14721:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: lamp50_1e38bc7c71802 X-Filterd-Recvd-Size: 1997 Message-ID: <1464898206.9273.2.camel@perches.com> Subject: Re: [PATCH] of: use pr_fmt prefix for all console printing From: Joe Perches To: Rob Herring , Frank Rowand Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pantelis Antoniou Date: Thu, 02 Jun 2016 13:10:06 -0700 In-Reply-To: References: <1464880499-29864-1-git-send-email-robh@kernel.org> <57506DDC.3060804@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-02 at 14:56 -0500, Rob Herring wrote: > On Thu, Jun 2, 2016 at 12:33 PM, Frank Rowand wrote: [] > > > @@ -355,8 +355,6 @@ int of_overlay_create(struct device_node *tree) > > > > > >       id = idr_alloc(&ov_idr, ov, 0, 0, GFP_KERNEL); > > >       if (id < 0) { > > > -             pr_err("%s: idr_alloc() failed for tree@%s\n", > > > -                             __func__, tree->full_name); > > Every other error in of_overlay_create() results in a pr_err(). > > (The other cases of removing pr_err() in this file are fine, because > > the errors are already reported in the functions called from this > > function.) > > > > I would recommend leaving in the pr_err() for idr_alloc() failure. > I was thinking idr_alloc is going to call kmalloc which will print > errors on failure, but there may be some case it doesn't. Only if __GFP_NOWARN is used. And it's not used in any idr_alloc call.