From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932608AbcFCSja (ORCPT ); Fri, 3 Jun 2016 14:39:30 -0400 Received: from us-mx1.synaptics.com ([192.147.44.131]:50447 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932299AbcFCSj2 (ORCPT ); Fri, 3 Jun 2016 14:39:28 -0400 From: Andrew Duggan To: , CC: Andrew Duggan , Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang , Nick Dyer Subject: [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node Date: Fri, 3 Jun 2016 11:39:13 -0700 Message-ID: <1464979153-2386-1-git-send-email-aduggan@synaptics.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.4.10.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Increment the refcount for the transport device's of_node before calling of_find_node_by_name(). Since of_find_node_by_name() assumes the refcount was incremented by the caller and calls of_node_put() when it is done. Signed-off-by: Andrew Duggan --- drivers/input/rmi4/rmi_bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index b368b05..55b5336 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers/input/rmi4/rmi_bus.c @@ -157,11 +157,12 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv) static void rmi_function_of_probe(struct rmi_function *fn) { char of_name[9]; + struct device_node *node = fn->rmi_dev->xport->dev->of_node; snprintf(of_name, sizeof(of_name), "rmi4-f%02x", fn->fd.function_number); - fn->dev.of_node = of_find_node_by_name( - fn->rmi_dev->xport->dev->of_node, of_name); + of_node_get(node); + fn->dev.of_node = of_find_node_by_name(node, of_name); } #else static inline void rmi_function_of_probe(struct rmi_function *fn) -- 2.5.0