From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbcFDR3I (ORCPT ); Sat, 4 Jun 2016 13:29:08 -0400 Received: from mail1.bemta8.messagelabs.com ([216.82.243.199]:55591 "EHLO mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbcFDR1z (ORCPT ); Sat, 4 Jun 2016 13:27:55 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRWlGSWpSXmKPExsVywNY2U3cWf3C 4wXlpi4VtS1gsLu+aw+bA5PF5k1wAYxRrZl5SfkUCa0bD9c/sBS+EK9bt/cbSwHhFsIuRk0NI YBejxLIL1l2MXED2IUaJc/9Xs8I5C1ffYYRwLjFKnHi0kAWiZS2jxM39TBCJLYwSD+/dZQdJs AkYSMy8A2GLCJxnkXh6KxfEZhbQk9h24ggziC0sEC1xovk3WA2LgIrEt13fgeIcHLwCXhIrT8 iBhCUE5CROHpvMCmJzAoWvPFjKBLHXU2LP/h5mCFtN4vDZR2wQ9cESczdsB7N5BQQlTs58wgK xVkLi4IsXzBMYhWchSc1CklrAyLSKUaM4tagstUjX0FgvqSgzPaMkNzEzR9fQwEIvN7W4ODE9 NScxqVgvOT93EyMwsOsZGBh3MN467nKIUZKDSUmUd+r8oHAhvqT8lMqMxOKM+KLSnNTiQ4wyH BxKErz1fMHhQoJFqempFWmZOcAYg0lLcPAoifAqAuNMiLe4IDG3ODMdInWKUZfj0PRra5mEWP Ly81KlxHm7QWYIgBRllObBjYDF+yVGWSlhXkYGBgYhnoLUotzMElT5V4ziHIxKwrwMIFN4MvN K4Da9AjqCCeiIgkf+IEeUJCKkpBoYPZ3n9VyZuFv0Tv2PE0s/V7Gk1iu9EbWef/fQCsVeibN/ vHxZe5XjF1+7fWehm4nzCss+u66Sv8u39t3OfWRyNFXty33OE++3Bvs7f1KNb/rnrbqeoWD5x tff+1vf7PTtain6dinmQCjLnuRmr7sTN+trh7ROmrNMp5FXNaujXz7z099ynfxuJZbijERDLe ai4kQAtlF9hfICAAA= X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-3.tower-99.messagelabs.com!1465061273!21612019!1 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , CC: Bryan Thompson Subject: [PATCH v3 13/30] staging: unisys: visorbus: Make visordriver_callback_lock a mutex Date: Sat, 4 Jun 2016 13:27:13 -0400 Message-ID: <1465061250-18551-14-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> References: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 04 Jun 2016 17:27:37.0100 (UTC) FILETIME=[6347CCC0:01D1BE86] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 +- drivers/staging/unisys/visorbus/visorbus_main.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h index 9bb88bb..3ba01cf 100644 --- a/drivers/staging/unisys/include/visorbus.h +++ b/drivers/staging/unisys/include/visorbus.h @@ -161,7 +161,7 @@ struct visor_device { struct timer_list timer; bool timer_active; bool being_removed; - struct semaphore visordriver_callback_lock; + struct mutex visordriver_callback_lock; bool pausing; bool resuming; u32 chipset_bus_no; diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c index e98e720..2e0eb03 100644 --- a/drivers/staging/unisys/visorbus/visorbus_main.c +++ b/drivers/staging/unisys/visorbus/visorbus_main.c @@ -574,7 +574,7 @@ visordriver_probe_device(struct device *xdev) if (!drv->probe) return -ENODEV; - down(&dev->visordriver_callback_lock); + mutex_lock(&dev->visordriver_callback_lock); dev->being_removed = false; res = drv->probe(dev); @@ -584,7 +584,7 @@ visordriver_probe_device(struct device *xdev) fix_vbus_dev_info(dev); } - up(&dev->visordriver_callback_lock); + mutex_unlock(&dev->visordriver_callback_lock); return res; } @@ -600,11 +600,11 @@ visordriver_remove_device(struct device *xdev) dev = to_visor_device(xdev); drv = to_visor_driver(xdev->driver); - down(&dev->visordriver_callback_lock); + mutex_lock(&dev->visordriver_callback_lock); dev->being_removed = true; if (drv->remove) drv->remove(dev); - up(&dev->visordriver_callback_lock); + mutex_unlock(&dev->visordriver_callback_lock); dev_stop_periodic_work(dev); put_device(&dev->device); @@ -764,7 +764,7 @@ create_visor_device(struct visor_device *dev) POSTCODE_LINUX_4(DEVICE_CREATE_ENTRY_PC, chipset_dev_no, chipset_bus_no, POSTCODE_SEVERITY_INFO); - sema_init(&dev->visordriver_callback_lock, 1); /* unlocked */ + mutex_init(&dev->visordriver_callback_lock); dev->device.bus = &visorbus_type; dev->device.groups = visorbus_channel_groups; device_initialize(&dev->device); -- 1.9.1