From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273AbcFDR2E (ORCPT ); Sat, 4 Jun 2016 13:28:04 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.11]:45164 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbcFDR1r (ORCPT ); Sat, 4 Jun 2016 13:27:47 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRWlGSWpSXmKPExsVywNY2U3cCf3C 4wbo4i4VtS1gsLu+aw+bA5PF5k1wAYxRrZl5SfkUCa0b7xOnMBR85KzY8/MHUwHiIo4uRi0NI YBejxIub95ghnEOMErOn7gByOCGcw6+DIRKXGCXmTjjLCOGsZZRY3nwQqmULo8S92w3sIC1sA gYSM+/cBbNFBM6zSDy9lQtiCwv4SVxuf8sIYrMIqEhc+3kMzOYV8JTofHYAbJ2EgJzEyWOTWU FsTgEviSsPljJBnOEpsWd/D9RJahKHzz5i62LkAKoPltj6XxlijKDEyZlPWEBsZgEJiYMvXjB PYBSahSQ1C0lqASPTKkaN4tSistQiXSMDvaSizPSMktzEzBxdQ0MjvdzU4uLE9NScxKRiveT8 3E2MwBCuZ2Bg3ME4q9HrEKMkB5OSKO/U+UHhQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4//MGh wsJFqWmp1akZeYAowkmLcHBoyTCa8QHlOYtLkjMLc5Mh0idYlSUEuftBkkIgCQySvPg2mARfI lRVkqYl5GBgUGIpyC1KDezBFX+FaM4B6OSMC8DyBSezLwSuOmvgBYzAS0ueOQPsrgkESEl1cA Y9TfcInvTgaNhDfuXiiyJt1c/nzonZJP8r3K5wvRatz/+n1pfnlmuMluw6uGJY3MqpFnSD7j/ Ujrzbkbe2aqfd6NnL/9dvVLo3Fz9V36TsrROXLghu/ybzKzamUxnT31YyX92/QKzCZwRk+RX+ r59NEmmTk7Pt+eLw/SjcdZ2/CbsGq4TGmrmKrEUZyQaajEXFScCAHnlzvfbAgAA X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-10.tower-200.messagelabs.com!1465061259!5341973!11 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 02/30] staging: unisys: visorchipset change -1 return value Date: Sat, 4 Jun 2016 13:27:02 -0400 Message-ID: <1465061250-18551-3-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> References: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 04 Jun 2016 17:27:35.0904 (UTC) FILETIME=[62914E00:01D1BE86] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Arfvidson This patch changes the vague -1 return value to -EINVAL It also modifies the caller of parahotplug_request_complete to check the return value and return appropriate result. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 5ba5936..7f44913 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -1613,7 +1613,7 @@ parahotplug_request_complete(int id, u16 active) } spin_unlock(¶hotplug_request_list_lock); - return -1; + return -EINVAL; } /* @@ -2036,11 +2036,14 @@ static ssize_t devicedisabled_store(struct device *dev, const char *buf, size_t count) { unsigned int id; + int err; if (kstrtouint(buf, 10, &id)) return -EINVAL; - parahotplug_request_complete(id, 0); + err = parahotplug_request_complete(id, 0); + if (err < 0) + return err; return count; } -- 1.9.1