From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbcFDR3e (ORCPT ); Sat, 4 Jun 2016 13:29:34 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.13]:17200 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbcFDR14 (ORCPT ); Sat, 4 Jun 2016 13:27:56 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRWlGSWpSXmKPExsVywNY2U7eHPzj coL/ZxmJh2xIWi8u75rA5MHl83iQXwBjFmpmXlF+RwJrxfslSxoIT3BXfNh5ia2Ds5+pi5OIQ EtjFKHH1xHxmCGc/o8SnV1MZIZxLjBINBzaxQjhrGSU2NS6AymxhlDixbgeQw8nBJmAgMfPOX XYQW0TgPIvE01u5ILawQJDE7lPXmEFsFgEViX8zt4LZvAKeEjN/XmICsSUE5CROHpvMCmJzCn hJXHmwFCwuBFSzZ38PM4StJnH47CM2iPpgicV/J7NBzBGUODnzCQuIzSwgIXHwxQvmCYyCs5C kZiFJLWBkWsWoUZxaVJZapGtkoJdUlJmeUZKbmJmja2hopJebWlycmJ6ak5hUrJecn7uJERiu 9QwMjDsYZzV6HWKU5GBSEuWdOj8oXIgvKT+lMiOxOCO+qDQntfgQowwHh5IE73/e4HAhwaLU9 NSKtMwcYOTApCU4eJREeI34gNK8xQWJucWZ6RCpU4yKUuK83SAJAZBERmkeXBssWi8xykoJ8z IyMDAI8RSkFuVmlqDKv2IU52BUEuZlAJnCk5lXAjf9FdBiJqDFBY/8QRaXJCKkpBoYT4qc1dR wXV3KZTDt6CbO9UJdGbfcDohN/DZxv4iIS3GK5ddHSQ/yOH+9mdP+q659BX9coemWBae/LV54 n2ONhfT3he+XfN5/dfq1naLr32Qeesfx7sif4lv5a42440sFhQXC0qXZyy8/8+QIl2DTW7Dhi a1IfkSX5754dSHhFTtzamatL1jqqMRSnJFoqMVcVJwIAGJ2Db/RAgAA X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-10.tower-200.messagelabs.com!1465061259!5341973!2 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 03/30] staging: unisys: iovmcall_gnuc.h change -1 return values Date: Sat, 4 Jun 2016 13:27:03 -0400 Message-ID: <1465061250-18551-4-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> References: <1465061250-18551-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 04 Jun 2016 17:27:36.0102 (UTC) FILETIME=[62AF8460:01D1BE86] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/iovmcall_gnuc.h b/drivers/staging/unisys/visorbus/iovmcall_gnuc.h index b08b6ec..98ea7f3 100644 --- a/drivers/staging/unisys/visorbus/iovmcall_gnuc.h +++ b/drivers/staging/unisys/visorbus/iovmcall_gnuc.h @@ -22,7 +22,7 @@ __unisys_vmcall_gnuc(unsigned long tuple, unsigned long reg_ebx, cpuid(0x00000001, &cpuid_eax, &cpuid_ebx, &cpuid_ecx, &cpuid_edx); if (!(cpuid_ecx & 0x80000000)) - return -1; + return -EPERM; __asm__ __volatile__(".byte 0x00f, 0x001, 0x0c1" : "=a"(result) : "a"(tuple), "b"(reg_ebx), "c"(reg_ecx)); @@ -40,7 +40,7 @@ __unisys_extended_vmcall_gnuc(unsigned long long tuple, cpuid(0x00000001, &cpuid_eax, &cpuid_ebx, &cpuid_ecx, &cpuid_edx); if (!(cpuid_ecx & 0x80000000)) - return -1; + return -EPERM; __asm__ __volatile__(".byte 0x00f, 0x001, 0x0c1" : "=a"(result) : "a"(tuple), "b"(reg_ebx), "c"(reg_ecx), "d"(reg_edx)); -- 1.9.1