From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969AbcFEUOJ (ORCPT ); Sun, 5 Jun 2016 16:14:09 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34933 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbcFEUOE (ORCPT ); Sun, 5 Jun 2016 16:14:04 -0400 From: Sudip Mukherjee To: Doug Ledford , Sean Hefty , Hal Rosenstock Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 1/2] IB/sysfs: fix NULL dereference Date: Sun, 5 Jun 2016 21:13:55 +0100 Message-Id: <1465157636-10120-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If stats->names is NULL or stats->num_counters <= 0 we are jumping to the error path where the for loop is freeing hsag->attrs[i]. But as i is initialized to 0 so i >= 0 will be true and the loop will execute once trying to free hsag->attrs[0]. But hsag is NULL still now leading to a NULL pointer dereference. Signed-off-by: Sudip Mukherjee --- drivers/infiniband/core/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index 5e573bb..fcf6f9c 100644 --- a/drivers/infiniband/core/sysfs.c +++ b/drivers/infiniband/core/sysfs.c @@ -891,7 +891,7 @@ static void setup_hw_stats(struct ib_device *device, struct ib_port *port, { struct attribute_group *hsag = NULL; struct rdma_hw_stats *stats; - int i = 0, ret; + int i = -1, ret; stats = device->alloc_hw_stats(device, port_num); -- 1.9.1