From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbcFEUOZ (ORCPT ); Sun, 5 Jun 2016 16:14:25 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33404 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbcFEUOG (ORCPT ); Sun, 5 Jun 2016 16:14:06 -0400 From: Sudip Mukherjee To: Doug Ledford , Sean Hefty , Hal Rosenstock Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 2/2] IB/sysfs: fix memory leak Date: Sun, 5 Jun 2016 21:13:56 +0100 Message-Id: <1465157636-10120-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465157636-10120-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1465157636-10120-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the allocation of hsag fails we were just returning but stats was not released. Signed-off-by: Sudip Mukherjee --- drivers/infiniband/core/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index fcf6f9c..8d8732c 100644 --- a/drivers/infiniband/core/sysfs.c +++ b/drivers/infiniband/core/sysfs.c @@ -906,7 +906,7 @@ static void setup_hw_stats(struct ib_device *device, struct ib_port *port, sizeof(void *) * (stats->num_counters + 1), GFP_KERNEL); if (!hsag) - return; + goto err; ret = device->get_hw_stats(device, stats, port_num, stats->num_counters); -- 1.9.1