From: Wanpeng Li <kernellwp@gmail.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Wanpeng Li" <wanpeng.li@hotmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Rik van Riel" <riel@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: [PATCH v4 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting
Date: Tue, 7 Jun 2016 16:33:09 +0800 [thread overview]
Message-ID: <1465288389-3542-3-git-send-email-wanpeng.li@hotmail.com> (raw)
In-Reply-To: <1465288389-3542-1-git-send-email-wanpeng.li@hotmail.com>
From: Wanpeng Li <wanpeng.li@hotmail.com>
This patch adds guest steal-time support to full dynticks CPU
time accounting. After the following commit:
ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")
... time sampling became jiffy based, even if it's still listened
to ring boundaries, so steal_account_process_tick() is reused
to account how many 'ticks' are stolen-time, after the last accumulation.
Suggested-and-Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
v3 -> v4:
* fix grammar errors, thanks Ingo
* cleanup fragile codes, thanks Ingo
v2 -> v3:
* convert steal time jiffies to cputime
v1 -> v2:
* fix divide zero bug, thanks Rik
kernel/sched/cputime.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 75f98c5..9ff036b 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -257,7 +257,7 @@ void account_idle_time(cputime_t cputime)
cpustat[CPUTIME_IDLE] += (__force u64) cputime;
}
-static __always_inline bool steal_account_process_tick(void)
+static __always_inline unsigned long steal_account_process_tick(void)
{
#ifdef CONFIG_PARAVIRT
if (static_key_false(¶virt_steal_enabled)) {
@@ -279,7 +279,7 @@ static __always_inline bool steal_account_process_tick(void)
return steal_jiffies;
}
#endif
- return false;
+ return 0;
}
/*
@@ -691,9 +691,13 @@ static cputime_t get_vtime_delta(struct task_struct *tsk)
static void __vtime_account_system(struct task_struct *tsk)
{
- cputime_t delta_cpu = get_vtime_delta(tsk);
+ cputime_t delta_time = get_vtime_delta(tsk);
+ cputime_t steal_time = jiffies_to_cputime(steal_account_process_tick());
- account_system_time(tsk, irq_count(), delta_cpu, cputime_to_scaled(delta_cpu));
+ if (steal_time < delta_time) {
+ delta_time -= steal_time;
+ account_system_time(tsk, irq_count(), delta_time, cputime_to_scaled(delta_time));
+ }
}
void vtime_account_system(struct task_struct *tsk)
@@ -718,13 +722,18 @@ void vtime_gen_account_irq_exit(struct task_struct *tsk)
void vtime_account_user(struct task_struct *tsk)
{
- cputime_t delta_cpu;
+ cputime_t delta_time, steal_time;
write_seqcount_begin(&tsk->vtime_seqcount);
tsk->vtime_snap_whence = VTIME_SYS;
if (vtime_delta(tsk)) {
- delta_cpu = get_vtime_delta(tsk);
- account_user_time(tsk, delta_cpu, cputime_to_scaled(delta_cpu));
+ delta_time = get_vtime_delta(tsk);
+ steal_time = jiffies_to_cputime(steal_account_process_tick());
+
+ if (steal_time < delta_time) {
+ delta_time -= steal_time;
+ account_user_time(tsk, delta_time, cputime_to_scaled(delta_time));
+ }
}
write_seqcount_end(&tsk->vtime_seqcount);
}
--
1.9.1
next prev parent reply other threads:[~2016-06-07 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 8:33 [PATCH v4 1/3] KVM: fix steal clock warp during guest cpu hotplug Wanpeng Li
2016-06-07 8:33 ` [PATCH v4 2/3] sched/cputime: Fix prev steal time accouting during " Wanpeng Li
2016-06-07 16:18 ` kbuild test robot
2016-06-07 8:33 ` Wanpeng Li [this message]
[not found] <1465661590-4732-1-git-send-email-wanpeng.li@hotmail.com>
[not found] ` <SG2PR02MB15501BB06CAE47E4406FF7AD805D0@SG2PR02MB1550.apcprd02.prod.outlook.com>
2016-06-07 10:47 ` [PATCH v4 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting Paolo Bonzini
2016-06-07 11:23 ` Wanpeng Li
2016-06-07 12:15 ` Wanpeng Li
2016-06-07 12:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465288389-3542-3-git-send-email-wanpeng.li@hotmail.com \
--to=kernellwp@gmail.com \
--cc=fweisbec@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®