From: Joe Perches <joe@perches.com>
To: Reinoud Koornstra <reinoudkoornstra@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: small patch to avoid warning in gcc 6
Date: Tue, 07 Jun 2016 17:47:46 -0700 [thread overview]
Message-ID: <1465346866.25087.45.camel@perches.com> (raw)
In-Reply-To: <CAAA5faEGRkKofEj9yPsD1LKKJph+c_SnuPgQ7cCohKnj2wAscg@mail.gmail.com>
On Tue, 2016-06-07 at 18:41 -0600, Reinoud Koornstra wrote:
> Hello Everybody,
>
> A small patch that doesn't really do anything other than getting rid
> of a warning in gcc 6.1.0.
>
> drivers/gpu/drm/i915/i915_debugfs.c: In function ‘i915_dump_lrc’:
> drivers/gpu/drm/i915/i915_debugfs.c:2060:6: warning: suggest explicit
> braces to avoid ambiguous ‘else’ [-Wparentheses]
> if (ctx != dev_priv->kernel_context)
> ^
Likely there should be 2 pairs of braces added:
list_for_each_entry(ctx, &dev_priv->context_list, link) {
if (ctx != dev_priv->kernel_context) {
for_each_ring(ring, dev_priv, i)
i915_dump_lrc_obj(m, ctx, ring);
}
}
next prev parent reply other threads:[~2016-06-08 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 0:41 Reinoud Koornstra
2016-06-08 0:47 ` Joe Perches [this message]
2016-06-08 0:52 ` Reinoud Koornstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465346866.25087.45.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinoudkoornstra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®