From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424242AbcFHJu5 (ORCPT ); Wed, 8 Jun 2016 05:50:57 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:6673 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1423076AbcFHJuy (ORCPT ); Wed, 8 Jun 2016 05:50:54 -0400 From: To: , , , , , CC: , , , , , , , , , , , , , , , , , , , , , Honghui Zhang Subject: [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate Date: Wed, 8 Jun 2016 17:50:44 +0800 Message-ID: <1465379444-14719-1-git-send-email-honghui.zhang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Honghui Zhang The device_node will be released in of_iommu_configure, it may be double released if call of_node_put in mtk_iommu_of_xlate. Signed-off-by: Honghui Zhang --- drivers/iommu/mtk_iommu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index c3043d8..493bd3e 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -455,7 +455,6 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args) if (!dev->archdata.iommu) { /* Get the m4u device */ m4updev = of_find_device_by_node(args->np); - of_node_put(args->np); if (WARN_ON(!m4updev)) return -EINVAL; -- 1.8.1.1.dirty