From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424995AbcFHLON (ORCPT ); Wed, 8 Jun 2016 07:14:13 -0400 Received: from ozlabs.org ([103.22.144.67]:52352 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbcFHLOK (ORCPT ); Wed, 8 Jun 2016 07:14:10 -0400 Message-ID: <1465384442.13854.2.camel@ellerman.id.au> Subject: Re: [PATCH] of: fix autoloading due to broken modalias with no 'compatible' From: Michael Ellerman To: Wolfram Sang , linuxppc-dev@lists.ozlabs.org Cc: devicetree@vger.kernel.org, Mathieu Malaterre , linux-kernel@vger.kernel.org, Andreas Schwab , Philipp Zabel Date: Wed, 08 Jun 2016 21:14:02 +1000 In-Reply-To: <1465231718-2577-1-git-send-email-wsa@the-dreams.de> References: <1465231718-2577-1-git-send-email-wsa@the-dreams.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-06 at 18:48 +0200, Wolfram Sang wrote: > Because of an improper dereference, a stray 'C' character was output to > the modalias when no 'compatible' was specified. This is the case for > some old PowerMac drivers which only set the 'name' property. Fix it to > let them match again. > > Reported-by: Mathieu Malaterre > Signed-off-by: Wolfram Sang > Tested-by: Mathieu Malaterre > Cc: Philipp Zabel > Cc: Andreas Schwab > Fixes: 6543becf26fff6 ("mod/file2alias: make modalias generation safe for cross compiling") > --- > > I think it makes sense if this goes in via ppc (with stable tag added). > D'accord? Sure, I've grabbed it. I added: Cc: stable@vger.kernel.org # v3.9+ cheers