From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933395AbcFHT7u (ORCPT ); Wed, 8 Jun 2016 15:59:50 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:35430 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcFHT7t (ORCPT ); Wed, 8 Jun 2016 15:59:49 -0400 From: Chris Cesare To: abbotti@mev.co.uk Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Chris Cesare Subject: [PATCH] staging: comedi: serial2002: bare unsigned and unneeded cast styling issues Date: Wed, 8 Jun 2016 15:59:31 -0400 Message-Id: <1465415971-30203-1-git-send-email-chris.cesare@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org checkpatch.pl reported two warnings: A bare "unsigned" and an unnecessary cast. Fixed both. Signed-off-by: Chris Cesare --- drivers/staging/comedi/drivers/serial2002.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c index 7a1defc..d3c2743 100644 --- a/drivers/staging/comedi/drivers/serial2002.c +++ b/drivers/staging/comedi/drivers/serial2002.c @@ -95,7 +95,7 @@ struct serial_data { #define S2002_CFG_SIGN(x) (((x) >> 13) & 0x1) #define S2002_CFG_BASE(x) (((x) >> 14) & 0xfffff) -static long serial2002_tty_ioctl(struct file *f, unsigned op, +static long serial2002_tty_ioctl(struct file *f, unsigned int op, unsigned long param) { if (f->f_op->unlocked_ioctl) @@ -379,7 +379,8 @@ static int serial2002_setup_subdevice(struct comedi_subdevice *s, range_table_list[chan] = (const struct comedi_lrange *)&range[j]; } - maxdata_list[chan] = ((long long)1 << cfg[j].bits) - 1; + maxdata_list[chan] = (1 << cfg[j].bits) - 1; + chan++; } } -- 2.7.4