mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasun Maiti <prasunmaiti87@gmail.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "ath6kl@lists.infradead.org" <ath6kl@lists.infradead.org>,
	Linux Next <linux-next@vger.kernel.org>,
	Linux Wireless <linux-wireless@vger.kernel.org>,
	Prasun Maiti <prasunmaii87@gmail.com>
Subject: [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns
Date: Thu,  9 Jun 2016 11:06:31 +0530	[thread overview]
Message-ID: <1465450591-23543-1-git-send-email-prasunmaiti87@gmail.com> (raw)
In-Reply-To: <CAGRGNgV4sL2TypkR+zsaDHN26KCF0kjtWPsi9y9D_JkGpvWrUw@mail.gmail.com>

Since add more warnings for inconsistent ops in cfg80211, the wireless
core warns if a driver implements a cfg80211 callback but doesn't
implements the inverse operation. The ath6kl driver implements a cfg80211
.get_antenna operation handler but doesn't have the inverse .set_antenna
callback. So, it makes warning.

To remove this warning, add .set_antenna callback in ath6kl driver which
is unimplemented.

Signed-off-by: Prasun Maiti <prasunmaiti87@gmail.com>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 4e11ba0..e638296 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -3231,6 +3231,16 @@ static int ath6kl_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
 					wait, buf, len, no_cck);
 }
 
+static int ath6kl_set_antenna(struct wiphy *wiphy,
+				u32 tx_ant, u32 rx_ant)
+{
+	/*
+	 * Note: This callback should be implement when firmware support this
+	 * command.
+	 */
+	return 0;
+}
+
 static int ath6kl_get_antenna(struct wiphy *wiphy,
 			      u32 *tx_ant, u32 *rx_ant)
 {
@@ -3456,6 +3466,7 @@ static struct cfg80211_ops ath6kl_cfg80211_ops = {
 	.cancel_remain_on_channel = ath6kl_cancel_remain_on_channel,
 	.mgmt_tx = ath6kl_mgmt_tx,
 	.mgmt_frame_register = ath6kl_mgmt_frame_register,
+	.set_antenna = ath6kl_set_antenna,
 	.get_antenna = ath6kl_get_antenna,
 	.sched_scan_start = ath6kl_cfg80211_sscan_start,
 	.sched_scan_stop = ath6kl_cfg80211_sscan_stop,
-- 
1.9.1

  parent reply	other threads:[~2016-06-09  5:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 12:21 [PATCH] Add .set_antenna callback in ath6kl driver to remove " Prasun Maiti
2016-06-08 14:21 ` kbuild test robot
2016-06-08 14:23 ` Valo, Kalle
2016-06-08 14:35   ` Prasun Maiti
2016-06-08 14:46     ` Valo, Kalle
2016-06-08 15:20       ` Prasun Maiti
2016-06-08 15:30         ` Valo, Kalle
2016-06-08 15:46           ` Prasun Maiti
2016-06-08 15:51             ` Ben Greear
2016-06-08 15:56               ` Prasun Maiti
2016-06-08 16:10                 ` Ben Greear
2016-06-09  0:05         ` Julian Calaby
2016-06-09  5:04           ` Prasun Maiti
2016-06-09  5:36           ` Prasun Maiti [this message]
2016-06-09  6:43             ` [PATCH] Add .set_antenna callback in ath6kl driver to fix " Johannes Berg
2016-06-09  7:08             ` Valo, Kalle
2016-06-08 15:09   ` Prasun Maiti
2016-06-11 20:33 ` [PATCH] Add .set_antenna callback in ath6kl driver to remove " kbuild test robot
2016-06-11 20:35 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465450591-23543-1-git-send-email-prasunmaiti87@gmail.com \
    --to=prasunmaiti87@gmail.com \
    --cc=ath6kl@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prasunmaii87@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®