mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthias Reichl <hias@horus.com>
To: Vinod Koul <vinod.koul@intel.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>
Cc: Martin Sperl <kernel@martin.sperl.org>,
	Clive Messer <clive.messer@digitaldreamtime.co.uk>,
	dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting
Date: Thu,  9 Jun 2016 13:41:43 +0200	[thread overview]
Message-ID: <1465472504-10191-2-git-send-email-hias@horus.com> (raw)
In-Reply-To: <1465472504-10191-1-git-send-email-hias@horus.com>

The code responsible for splitting periods into chunks that
can be handled by the DMA controller missed to update total_len,
the number of bytes processed in the current period, when there
are more chunks to follow.

Therefore total_len was stuck at 0 and the code didn't work at all.
This resulted in a wrong control block layout and audio issues because
the cyclic DMA callback wasn't executing on period boundaries.

Fix this by adding the missing total_len update.

Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Tested-by: Clive Messer <clive.messer@digitaldreamtime.co.uk>
---
 drivers/dma/bcm2835-dma.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 6149b27..344bcf92 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -251,8 +251,11 @@ static void bcm2835_dma_create_cb_set_length(
 	 */
 
 	/* have we filled in period_length yet? */
-	if (*total_len + control_block->length < period_len)
+	if (*total_len + control_block->length < period_len) {
+		/* update number of bytes in this period so far */
+		*total_len += control_block->length;
 		return;
+	}
 
 	/* calculate the length that remains to reach period_length */
 	control_block->length = period_len - *total_len;
-- 
2.1.4

  reply	other threads:[~2016-06-09 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 11:41 [PATCH 0/2] dmaengine: bcm2835: Cyclic DMA fixes Matthias Reichl
2016-06-09 11:41 ` Matthias Reichl [this message]
2016-06-14  4:49   ` [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting Eric Anholt
2016-06-09 11:41 ` [PATCH 2/2] dmaengine: bcm2835: Avoid splitting periods into very small chunks Matthias Reichl
2016-06-14  5:06   ` Eric Anholt
2016-06-19 10:39     ` Matthias Reichl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465472504-10191-2-git-send-email-hias@horus.com \
    --to=hias@horus.com \
    --cc=clive.messer@digitaldreamtime.co.uk \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=kernel@martin.sperl.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=swarren@wwwdotorg.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®