From: David Howells <dhowells@redhat.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: dhowells@redhat.com, matt@codeblueprint.co.uk,
ard.biesheuvel@linaro.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] efi: Get the secure boot status [ver #5]
Date: Thu, 08 Dec 2016 17:31:13 +0000 [thread overview]
Message-ID: <14655.1481218273@warthog.procyon.org.uk> (raw)
In-Reply-To: <20161208124236.GA8757@wunner.de>
Lukas Wunner <lukas@wunner.de> wrote:
> > +out_efi_err:
> > + pr_efi_err(sys_table_arg, "Could not determine UEFI Secure Boot status.\n");
> > + if (status == EFI_NOT_FOUND)
> > + return efi_secureboot_mode_disabled;
> > + return efi_secureboot_mode_unknown;
> > +}
>
> In the out_efi_err path, the if-statement needs to come before the
> pr_efi_err() call. Otherwise it would be a change of behaviour for
> ARM to what we have now.
As I understand it, if the BIOS is an EFI BIOS, these variables must exist -
in which case I would argue that the pr_efi_err-statement should be before the
if-statement.
David
next prev parent reply other threads:[~2016-12-08 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 13:18 [PATCH 0/8] efi: Pass secure boot mode to kernel " David Howells
2016-12-07 13:18 ` [PATCH 1/8] efi: use typed function pointers for runtime services table " David Howells
2016-12-07 13:18 ` [PATCH 2/8] x86/efi: Allow invocation of arbitrary runtime services " David Howells
2016-12-07 13:18 ` [PATCH 3/8] arm/efi: " David Howells
2016-12-07 13:18 ` [PATCH 4/8] efi: Add SHIM and image security database GUID definitions " David Howells
2016-12-07 13:18 ` [PATCH 5/8] efi: Get the secure boot status " David Howells
2016-12-08 6:57 ` Lukas Wunner
2016-12-08 8:16 ` David Howells
2016-12-08 12:42 ` Lukas Wunner
2016-12-08 17:31 ` David Howells [this message]
2016-12-09 0:35 ` Lukas Wunner
2016-12-07 13:18 ` [PATCH 6/8] efi: Disable secure boot if shim is in insecure mode " David Howells
2016-12-07 13:18 ` [PATCH 7/8] efi: Add EFI_SECURE_BOOT bit " David Howells
2016-12-07 13:19 ` [PATCH 8/8] efi: Handle secure boot from UEFI-2.6 " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14655.1481218273@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matt@codeblueprint.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome