From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 4/6] staging: i4l: icn: remove braces
Date: Sat, 11 Jun 2016 22:10:53 +0100 [thread overview]
Message-ID: <1465679455-21152-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1465679455-21152-1-git-send-email-sudipm.mukherjee@gmail.com>
Braces are not required in a single statement block.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/staging/i4l/icn/icn.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index abc6599..ff0fb6c6 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b/drivers/staging/i4l/icn/icn.c
@@ -883,9 +883,8 @@ icn_loadboot(u_char __user *buffer, icn_card *card)
SLEEP(1);
OUTB_P(0xff, ICN_RUN); /* Start Boot-Code */
ret = icn_check_loader(card->doubleS0 ? 2 : 1);
- if (ret) {
+ if (ret)
goto out_kfree;
- }
if (!card->doubleS0) {
ret = 0;
goto out_kfree;
@@ -1274,9 +1273,8 @@ icn_command(isdn_ctrl *c, icn_card *card)
if (a) {
if (!card->leased) {
card->leased = 1;
- while (card->ptype == ISDN_PTYPE_UNKNOWN) {
+ while (card->ptype == ISDN_PTYPE_UNKNOWN)
msleep_interruptible(ICN_BOOT_TIMEOUT1);
- }
msleep_interruptible(ICN_BOOT_TIMEOUT1);
sprintf(cbuf, "00;FV2ON\n01;EAZ%c\n02;EAZ%c\n",
(a & 1) ? '1' : 'C', (a & 2) ? '2' : 'C');
@@ -1576,9 +1574,8 @@ icn_addcard(int port, char *id1, char *id2)
icn_card *card2;
card = icn_initcard(port, id1);
- if (!card) {
+ if (!card)
return -EIO;
- }
if (!strlen(id2)) {
printk(KERN_INFO
"icn: (%s) ICN-2B, port 0x%x added\n",
--
1.9.1
next prev parent reply other threads:[~2016-06-11 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 21:10 [PATCH 1/6] staging: i4l: icn: do not use return as a function Sudip Mukherjee
2016-06-11 21:10 ` [PATCH 2/6] staging: i4l: icn: donot assign in if statement Sudip Mukherjee
2016-06-11 21:10 ` [PATCH 3/6] staging: i4l: icn: space not needed after cast Sudip Mukherjee
2016-06-11 21:10 ` Sudip Mukherjee [this message]
2016-06-11 21:10 ` [PATCH 5/6] staging: i4l: icn: remove blank lines Sudip Mukherjee
2016-06-11 21:10 ` [PATCH 6/6] staging: i4l: icn: fix incorrect type of arguments Sudip Mukherjee
2016-06-11 21:14 ` [PATCH 6/6 v2] " Sudip Mukherjee
2016-06-15 20:29 ` [PATCH 1/6] staging: i4l: icn: do not use return as a function Luis de Bethencourt
2016-08-21 15:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465679455-21152-4-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome