From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422874AbcFMXcg (ORCPT ); Mon, 13 Jun 2016 19:32:36 -0400 Received: from m12-11.163.com ([220.181.12.11]:49924 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbcFMXcf (ORCPT ); Mon, 13 Jun 2016 19:32:35 -0400 From: weiyj_lk@163.com To: Kishon Vijay Abraham I , Heiko Stuebner Cc: Wei Yongjun , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() Date: Mon, 13 Jun 2016 23:31:47 +0000 Message-Id: <1465860707-26005-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.5.5 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-CM-TRANSID: C8CowACHhV5jQl9XVAAyAA--.22466S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kZr1rZrWUGw4kXFWUArb_yoW3CFg_C3 yrZrnrXr4ktF1FgryUGFy3u3sIy3Wqgr4ruFnaya4aya4DK34Fqr95Zws8JFnrWwsxJFZx Cw1qvr1xCryxJjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUn4q2tUUUUU== X-Originating-IP: [180.102.102.213] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiRwWH1lc63zFEwAAAsU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun In case of error, the function devm_kzalloc() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/phy/phy-rockchip-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-rockchip-dp.c b/drivers/phy/phy-rockchip-dp.c index 793ecb6..8b267a7 100644 --- a/drivers/phy/phy-rockchip-dp.c +++ b/drivers/phy/phy-rockchip-dp.c @@ -90,7 +90,7 @@ static int rockchip_dp_phy_probe(struct platform_device *pdev) return -ENODEV; dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL); - if (IS_ERR(dp)) + if (!dp) return -ENOMEM; dp->dev = dev;